64361 - Should not be prompted to save form data if data has already been saved

Status: VERIFIED FIXED

(Toolkit :: Form Manager, defect, P2)

Description

[Terri Preston]

1. Go to a sight and enter form data (I went to amazon and started to make a 
purchase)
2. When you get to the address form, fill in and save form data from form 
manager toolbar
3. Click continue

Expected results: should go to next page without a dialog

Actual results: a dialog comes up asking if you would like to save the form data

Form Manager should know that this info. has already been captured and not ask 
to save a second time

Comment 1

[Viswanath Ramachandran]

nav triage team: this is a P2. does this only happen with the toolbar, in that
case it is not a beta stopper. thanks, 

Comment 2

[Stephen P. Morse]

Esculating to M0.9 because this is a very visible bug.

(It is independent of the form toolbar.)

Comment 3

[Stephen P. Morse]

Attachment: patch to determine if form has some unsaved values

Comment 4

[Stephen P. Morse]

Attachment: Patch to include missing initializations

Comment 5

[Samir Gehani]

r=sgehani

Comment 6

[Stephen P. Morse]

cc'ing alecf for superreview.

Comment 7

[Stephen P. Morse]

Per vishy's request, my recommendation for this is nsbeta1+.  Furthermore, 
already have reviewed patch and am simply awaiting super-review.

Comment 8

[Alec Flett]

sounds good.
sr=alecf

Comment 9

[Stephen P. Morse]

Fix checked in.

Comment 10

[Terri Preston]

Verified checked into lxr.mozilla.org