bug # 133119 changed pref w/o change the entities

RESOLVED FIXED in seamonkey2.1b3

Status

SeaMonkey
Preferences
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: ewong, Assigned: ewong)

Tracking

Trunk
seamonkey2.1b3
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(blocking-seamonkey2.1 b3+)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

6 years ago
Bug #133119 made changes to the Image Acceptance Policy pref panel, but
did not change the entities.  This bug should fix this so localizers can
tell what was changed.

Updated

6 years ago
blocking-seamonkey2.1: --- → b3+
(Assignee)

Comment 1

6 years ago
Created attachment 520871 [details] [diff] [review]
Changed entities which were not changed in bug #133119.
Attachment #520871 - Flags: review?(iann_bugzilla)
(Assignee)

Comment 2

6 years ago
Created attachment 520876 [details] [diff] [review]
Update entities from changes from bug #1331199. (v2)
Attachment #520871 - Attachment is obsolete: true
Attachment #520871 - Flags: review?(iann_bugzilla)
Attachment #520876 - Flags: review?(iann_bugzilla)

Comment 3

6 years ago
Comment on attachment 520876 [details] [diff] [review]
Update entities from changes from bug #1331199. (v2)

Only the wording was changed, not the meaning, but I suppose it gives localisers another chance to consider their translation.
Attachment #520876 - Flags: review?(iann_bugzilla) → review+
Blocks: 133119
Flags: in-testsuite-
Hardware: x86 → All
(Assignee)

Updated

6 years ago
Attachment #520876 - Flags: ui-review?(neil)
Edmund, there is no UI change involved here so no need for a UI review. You're good to go! :-)

Comment 5

6 years ago
Comment on attachment 520876 [details] [diff] [review]
Update entities from changes from bug #1331199. (v2)

>+        <radio value="2" label="&doNotLoadImages.label;"
>+               accesskey="&doNotLoadImages.accesskey;"/>
While you're here, please rename this entity so that it ends in Radio like the other two. (If you think doNotLoadImagesRadio is too long, you could try loadNoImagesRadio instead.)
Attachment #520876 - Flags: ui-review?(neil) → ui-review+
(Assignee)

Comment 6

6 years ago
Created attachment 521484 [details] [diff] [review]
Updated entities on changes from bug #133119. [Checkin: comment 7]
Attachment #520876 - Attachment is obsolete: true
Attachment #521484 - Flags: ui-review+
Attachment #521484 - Flags: review+
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
Comment on attachment 521484 [details] [diff] [review]
Updated entities on changes from bug #133119. [Checkin: comment 7]

http://hg.mozilla.org/comm-central/rev/2d4ccfcaf4b7
Attachment #521484 - Attachment description: Updated entities on changes from bug #133119. → Updated entities on changes from bug #133119. [Checkin: comment 7]
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1b3
You need to log in before you can comment on or make changes to this bug.