Last Comment Bug 643676 - bug # 133119 changed pref w/o change the entities
: bug # 133119 changed pref w/o change the entities
Status: RESOLVED FIXED
:
Product: SeaMonkey
Classification: Client Software
Component: Preferences (show other bugs)
: Trunk
: All All
: -- normal (vote)
: seamonkey2.1b3
Assigned To: Edmund Wong (:ewong)
:
Mentors:
Depends on:
Blocks: 133119
  Show dependency treegraph
 
Reported: 2011-03-21 23:24 PDT by Edmund Wong (:ewong)
Modified: 2011-03-24 15:36 PDT (History)
3 users (show)
bugzillamozillaorg_serge_20140323: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
b3+


Attachments
Changed entities which were not changed in bug #133119. (1.91 KB, patch)
2011-03-21 23:46 PDT, Edmund Wong (:ewong)
no flags Details | Diff | Splinter Review
Update entities from changes from bug #1331199. (v2) (3.34 KB, patch)
2011-03-22 00:59 PDT, Edmund Wong (:ewong)
iann_bugzilla: review+
neil: ui‑review+
Details | Diff | Splinter Review
Updated entities on changes from bug #133119. [Checkin: comment 7] (3.34 KB, patch)
2011-03-24 07:07 PDT, Edmund Wong (:ewong)
ewong: review+
ewong: ui‑review+
Details | Diff | Splinter Review

Description Edmund Wong (:ewong) 2011-03-21 23:24:15 PDT
Bug #133119 made changes to the Image Acceptance Policy pref panel, but
did not change the entities.  This bug should fix this so localizers can
tell what was changed.
Comment 1 Edmund Wong (:ewong) 2011-03-21 23:46:12 PDT
Created attachment 520871 [details] [diff] [review]
Changed entities which were not changed in bug #133119.
Comment 2 Edmund Wong (:ewong) 2011-03-22 00:59:35 PDT
Created attachment 520876 [details] [diff] [review]
Update entities from changes from bug #1331199. (v2)
Comment 3 Ian Neal 2011-03-22 06:39:56 PDT
Comment on attachment 520876 [details] [diff] [review]
Update entities from changes from bug #1331199. (v2)

Only the wording was changed, not the meaning, but I suppose it gives localisers another chance to consider their translation.
Comment 4 Jens Hatlak (:InvisibleSmiley) 2011-03-23 02:27:14 PDT
Edmund, there is no UI change involved here so no need for a UI review. You're good to go! :-)
Comment 5 neil@parkwaycc.co.uk 2011-03-23 02:48:37 PDT
Comment on attachment 520876 [details] [diff] [review]
Update entities from changes from bug #1331199. (v2)

>+        <radio value="2" label="&doNotLoadImages.label;"
>+               accesskey="&doNotLoadImages.accesskey;"/>
While you're here, please rename this entity so that it ends in Radio like the other two. (If you think doNotLoadImagesRadio is too long, you could try loadNoImagesRadio instead.)
Comment 6 Edmund Wong (:ewong) 2011-03-24 07:07:32 PDT
Created attachment 521484 [details] [diff] [review]
Updated entities on changes from bug #133119. [Checkin: comment 7]
Comment 7 Jens Hatlak (:InvisibleSmiley) 2011-03-24 15:35:39 PDT
Comment on attachment 521484 [details] [diff] [review]
Updated entities on changes from bug #133119. [Checkin: comment 7]

http://hg.mozilla.org/comm-central/rev/2d4ccfcaf4b7

Note You need to log in before you can comment on or make changes to this bug.