Last Comment Bug 643677 - bug #133119 changed the Image Acceptance Policy prefs. Help needs updating.
: bug #133119 changed the Image Acceptance Policy prefs. Help needs updating.
Status: RESOLVED FIXED
:
Product: SeaMonkey
Classification: Client Software
Component: Help Documentation (show other bugs)
: Trunk
: All All
: -- normal (vote)
: seamonkey2.1b3
Assigned To: Edmund Wong (:ewong)
:
:
Mentors:
Depends on: 133119
Blocks:
  Show dependency treegraph
 
Reported: 2011-03-21 23:26 PDT by Edmund Wong (:ewong)
Modified: 2011-03-22 13:08 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Updated Image Acceptance Policy Pref help from changes from bug #133119. (1.47 KB, patch)
2011-03-21 23:38 PDT, Edmund Wong (:ewong)
jh: review-
Details | Diff | Splinter Review
Updated Help from bug #133119 changes. [Checkin: comment 4] (1.47 KB, patch)
2011-03-22 06:33 PDT, Edmund Wong (:ewong)
jh: review+
Details | Diff | Splinter Review

Description Edmund Wong (:ewong) 2011-03-21 23:26:10 PDT
Update the help in accordance to the changes as made in #133119 (or
subsequently #643676).
Comment 1 Edmund Wong (:ewong) 2011-03-21 23:38:03 PDT
Created attachment 520870 [details] [diff] [review]
Updated Image Acceptance Policy Pref help from changes from bug #133119.
Comment 2 Jens Hatlak (:InvisibleSmiley) 2011-03-22 01:43:37 PDT
Comment on attachment 520870 [details] [diff] [review]
Updated Image Acceptance Policy Pref help from changes from bug #133119.

>-  <li><strong>Accept images that come from the originating server
>-    only</strong>: Select this option if you do not want to load images from
>+  <li><strong>Load only images that come from the originating server
>+    </strong>: Select this option if you do not want to load images from
>     third-party websites.</li>

Actually this is a case where copy/paste is good. Use it and you'll see that the string here is not equal to the one added through bug 133119.

Also please don't have whitespace between text and directly enclosing tags, in this case "server" and "</strong>". If wrapping needs so be applied, also move the word to the next line ("server</strong>"). Exception from the rule: In case the closing tag is the last one on the line (like "websites.</li>"), you may keep it where it is if the overhead is less than say four characters and the word before it is long.

For the general case that means if in the end you need to re-wrap a whole paragraph, that's OK.

Minus'ing for the moment, but just because I want to see a new patch and have some time to double-check the old strings are not used elsewhere in Help (which I cannot do from here).
Comment 3 Edmund Wong (:ewong) 2011-03-22 06:33:11 PDT
Created attachment 520901 [details] [diff] [review]
Updated Help from bug #133119 changes. [Checkin: comment 4]
Comment 4 Jens Hatlak (:InvisibleSmiley) 2011-03-22 13:07:56 PDT
Comment on attachment 520901 [details] [diff] [review]
Updated Help from bug #133119 changes. [Checkin: comment 4]

http://hg.mozilla.org/comm-central/rev/55b2258fab38

Note You need to log in before you can comment on or make changes to this bug.