Closed Bug 643715 Opened 14 years ago Closed 13 years ago

'Remove bookmark' via star in URL bar fails, then disappears completely

Categories

(Firefox :: Bookmarks & History, defect)

Product:
Firefox
Component:
Bookmarks & History
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED WORKSFORME

People

(Reporter: aelilea, Unassigned)

Details

(Whiteboard: [places-next-wanted][needs investigation])

User-Agent: Mozilla/5.0 (X11; Linux i686; rv:2.0) Gecko/20100101 Firefox/4.0 Build Identifier: Mozilla/5.0 (X11; Linux i686; rv:2.0) Gecko/20100101 Firefox/4.0 See below. Maybe a timing issue when steps 1-2 follow rapidly? Reproducible: Always Steps to Reproduce: 1. Bookmark a page by clicking the star in the URL bar 2. Change your mind and click again to bring up the popup bookmark options box 3. Click 'Remove bookmark' - the star fails to disappear 4. Click the star again. The title of the popup now reads "Page bookmarked" and the popup no longer has a 'Remove' button. 5. Even on closing the tab and opening the same URL again in a new tab, the bookmark cannot be removed via clicking the star (see 4) 6. After restarting FF, behaviour is back to normal and the bookmark can be removed.
Mozilla/5.0 (X11; Linux i686; rv:2.0) Gecko/20100101 Firefox/4.0 I am unable to reproduce the issue you have logged. Can you please try reproducing the issue with a clean profile: http://support.mozilla.com/en-US/kb/Managing%20profiles
Version: unspecified → Trunk
Sorry, I should have set "Reproducible" to "Intermittent". The key indicator is the display of the bookmark popup with "Page bookmarked" as the title (and no 'Remove' button). I am also so far unable to reproduce the issue with a clean profile. However, with a clean profile I also *never* manage to get the bookmark popup with a "Page bookmarked" title (instead of "Edit this bookmark"), so this may be an indication of where the problem is. I have no bookmark-related addons. Any particular config settings I should look at?
do you see any empty (missing text) buttons in the dialog when this happens?
No - screenshot: http://imgur.com/UYO9X It might help to understand when this particular popup is supposed to appear (rather than the normal one)?
are you sure you don't ave any add-on causing this? Did you try in safe mode? http://support.mozilla.com/kb/Safe+Mode The fact you cannot reproduce in a clean profile seems to call for add-on badly interacting with Firefox.
I have tried this in safe mode and can still consistently reproduce the problem. It seems to arise in particular when FF is doing other things in the background (eg. loading pages), but this may just be coincidence.
(In reply to comment #5) > The fact you cannot reproduce in a clean profile seems to call for add-on badly > interacting with Firefox. Tend to agree with Marco. If you cannot reproduce it on a clean profile it must be an add-on. Tried reproducing without succes: 1. While in safe mode - add-ons disabled 2. While FF is loading pages in the background - see Comment 6
Since it still happens with all add-ons disabled, the only remaining thing I can think of trying is reproducing my setup from a clean profile by importing bookmarks and tab groups etc. Will try this over the weekend. Meanwhile, it would help if someone familiar with the code could point out when the remove-button-free popup in the screenshot (comment 4) is actually *supposed* to appear, since when I get it it is a sign that there is a problem. To put it another way - can anyone reproduce that popup?
That popup appears on CTRL+D, should not be triggered by the star... I guess if there is a relationwith invoking mixed mode (keyboard and mouse).
Whiteboard: [places-next-wanted][needs investigation]
Have now taken a clean profile, added back ~60 open tabs and my bookmarks via sync, and the behaviour is again there.
I've looked a bit at the code, there is a third case when Page bookmarked can appear and is related to some sort of out-of-sync with this._batching. At first look I would have expected this to happen due to the same bug we fixed in bug 620789. But since it's still here must be some other timing related issue, I'll try to better follow what happens when clicking Remove Bookmark.
Bug still present in FF 5.0rc.
Mozilla/5.0 (X11; Linux i686; rv:8.0a1) Gecko/20110724 Firefox/8.0a1 Is it still present in the latest trunk? http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-trunk/
I have not encountered it any more since Aurora 7.
Mozilla/5.0 (X11; Linux i686; rv:8.0a1) Gecko/20110803 Firefox/8.0a1 Considering Comment 14 setting status to Resolved WFM
Status: UNCONFIRMED → RESOLVED
Closed: 13 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.