Closed Bug 643753 Opened 9 years ago Closed 9 years ago

Wrong dbghelp.lib linking argument for mingw compilation

Categories

(Firefox Build System :: General, defect)

x86
Windows XP
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla5

People

(Reporter: jacek, Assigned: jacek)

Details

(Whiteboard: fixed-in-bs)

Attachments

(1 file)

Attached patch fix v1.0Splinter Review
Linker options should use EXPAND_LIBNAME instead of hardcoding .lib file name directly. While I was at this, I've moved dbghelp importing from libxul-config.mk to Makefile.in since other libs are imported there and we don't need MOZ_IPC check anymore.
Attachment #520921 - Flags: review?(khuey)
Assignee: nobody → jacek
Thanks for the review, pushed to b-s:

http://hg.mozilla.org/projects/build-system/rev/c7bfc7dfba88
Whiteboard: fixed-in-bs
http://hg.mozilla.org/mozilla-central/rev/c7bfc7dfba88
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.2
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.