Closed
Bug 643753
Opened 14 years ago
Closed 14 years ago
Wrong dbghelp.lib linking argument for mingw compilation
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla5
People
(Reporter: jacek, Assigned: jacek)
Details
(Whiteboard: fixed-in-bs)
Attachments
(1 file)
|
1.48 KB,
patch
|
khuey
:
review+
|
Details | Diff | Splinter Review |
Linker options should use EXPAND_LIBNAME instead of hardcoding .lib file name directly. While I was at this, I've moved dbghelp importing from libxul-config.mk to Makefile.in since other libs are imported there and we don't need MOZ_IPC check anymore.
Attachment #520921 -
Flags: review?(khuey)
|
Assignee | |
Updated•14 years ago
|
Assignee: nobody → jacek
Attachment #520921 -
Flags: review?(khuey) → review+
|
|
Assignee | |
Comment 1•14 years ago
|
||
Thanks for the review, pushed to b-s:
http://hg.mozilla.org/projects/build-system/rev/c7bfc7dfba88
Whiteboard: fixed-in-bs
|
||
Comment 2•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.2
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•