Move snapToGrid, pageProperties and publishSettings from editorOverlay to editor

RESOLVED FIXED in seamonkey2.1b3

Status

SeaMonkey
Composer
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Ian Neal, Assigned: Ian Neal)

Tracking

(Blocks: 1 bug)

Trunk
seamonkey2.1b3
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

6 years ago
Created attachment 520923 [details] [diff] [review]
Move snapToGrid, pageProperties and publishSettings patch v1.0

The elements snapToGrid, pageProperties and publishSettings are only used by Composer and not by messagecompose or the text editor so should be moved out of editorOverlay and into editor.

This patch does that and moves their entities too.
Attachment #520923 - Flags: review?(neil)
(Assignee)

Updated

6 years ago
Attachment #520923 - Flags: review?(bugzilla)
(Assignee)

Updated

6 years ago
Attachment #520923 - Flags: review?(neil)
Attachment #520923 - Flags: review?(bugzilla)
(Assignee)

Comment 1

6 years ago
Created attachment 520956 [details] [diff] [review]
Move snapToGrid, pageProperties and publishSettings patch v1.1

Changes since v1.0:
* Forgot about cmd_propertiesPage command so move it too.
Attachment #520923 - Attachment is obsolete: true
Attachment #520956 - Flags: review?(neil)
(Assignee)

Updated

6 years ago
Attachment #520956 - Flags: review?(neil)
(Assignee)

Comment 2

6 years ago
Created attachment 522254 [details] [diff] [review]
Move snapToGrid, pageProperties and publishSettings patch v1.2 [Checked in: Comment 4]

Changes since v1.1:
* As publish is wanted in the text editor then publishSettings should be available in it to, so move publishSettings into editorOverlay.
Attachment #520956 - Attachment is obsolete: true
Attachment #522254 - Flags: review?(neil)

Updated

6 years ago
Attachment #522254 - Flags: review?(neil) → review+
(Assignee)

Comment 3

6 years ago
Comment on attachment 522254 [details] [diff] [review]
Move snapToGrid, pageProperties and publishSettings patch v1.2 [Checked in: Comment 4]

Requesting r for entity changes that affect TB
Attachment #522254 - Flags: review?(bugzilla)
(Assignee)

Updated

6 years ago
Attachment #522254 - Flags: review?(bugzilla) → review?(bienvenu)

Updated

6 years ago
Attachment #522254 - Flags: review?(bienvenu) → review+
(Assignee)

Updated

6 years ago
Attachment #522254 - Attachment description: Move snapToGrid, pageProperties and publishSettings patch v1.2 → Move snapToGrid, pageProperties and publishSettings patch v1.2 [Checked in: Comment 4]
(Assignee)

Comment 4

6 years ago
Comment on attachment 522254 [details] [diff] [review]
Move snapToGrid, pageProperties and publishSettings patch v1.2 [Checked in: Comment 4]

http://hg.mozilla.org/comm-central/rev/0b6d0aee59eb
(Assignee)

Updated

6 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1b3
You need to log in before you can comment on or make changes to this bug.