Last Comment Bug 643761 - Move snapToGrid, pageProperties and publishSettings from editorOverlay to editor
: Move snapToGrid, pageProperties and publishSettings from editorOverlay to editor
Status: RESOLVED FIXED
:
Product: SeaMonkey
Classification: Client Software
Component: Composer (show other bugs)
: Trunk
: All All
: -- normal (vote)
: seamonkey2.1b3
Assigned To: Ian Neal
:
Mentors:
Depends on:
Blocks: editorOverlaytidy
  Show dependency treegraph
 
Reported: 2011-03-22 08:37 PDT by Ian Neal
Modified: 2011-04-03 14:34 PDT (History)
1 user (show)
iann_bugzilla: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Move snapToGrid, pageProperties and publishSettings patch v1.0 (8.27 KB, patch)
2011-03-22 08:37 PDT, Ian Neal
no flags Details | Diff | Splinter Review
Move snapToGrid, pageProperties and publishSettings patch v1.1 (9.55 KB, patch)
2011-03-22 10:33 PDT, Ian Neal
no flags Details | Diff | Splinter Review
Move snapToGrid, pageProperties and publishSettings patch v1.2 [Checked in: Comment 4] (10.18 KB, patch)
2011-03-27 15:28 PDT, Ian Neal
neil: review+
mozilla: review+
Details | Diff | Splinter Review

Description Ian Neal 2011-03-22 08:37:37 PDT
Created attachment 520923 [details] [diff] [review]
Move snapToGrid, pageProperties and publishSettings patch v1.0

The elements snapToGrid, pageProperties and publishSettings are only used by Composer and not by messagecompose or the text editor so should be moved out of editorOverlay and into editor.

This patch does that and moves their entities too.
Comment 1 Ian Neal 2011-03-22 10:33:07 PDT
Created attachment 520956 [details] [diff] [review]
Move snapToGrid, pageProperties and publishSettings patch v1.1

Changes since v1.0:
* Forgot about cmd_propertiesPage command so move it too.
Comment 2 Ian Neal 2011-03-27 15:28:00 PDT
Created attachment 522254 [details] [diff] [review]
Move snapToGrid, pageProperties and publishSettings patch v1.2 [Checked in: Comment 4]

Changes since v1.1:
* As publish is wanted in the text editor then publishSettings should be available in it to, so move publishSettings into editorOverlay.
Comment 3 Ian Neal 2011-03-29 15:05:49 PDT
Comment on attachment 522254 [details] [diff] [review]
Move snapToGrid, pageProperties and publishSettings patch v1.2 [Checked in: Comment 4]

Requesting r for entity changes that affect TB
Comment 4 Ian Neal 2011-04-03 14:34:21 PDT
Comment on attachment 522254 [details] [diff] [review]
Move snapToGrid, pageProperties and publishSettings patch v1.2 [Checked in: Comment 4]

http://hg.mozilla.org/comm-central/rev/0b6d0aee59eb

Note You need to log in before you can comment on or make changes to this bug.