643773 - "ASSERTION: CheckLoadURIWithPrincipal must have a principal" with InstallTrigger

Status: RESOLVED FIXED

(Core :: Security: CAPS, defect)

Description

[Jesse Ruderman]

Attachment: testcase

###!!! ASSERTION: CheckLoadURIWithPrincipal must have a principal: 'aPrincipal', file caps/src/nsScriptSecurityManager.cpp, line 1397

Comment 1

[Jesse Ruderman]

Attachment: stack trace

Comment 2

[Daniel Veditz [:dveditz]]

jst thinks the fact that the principal is null may imply some of the JS this passes through is chrome-privileged code. Not sure if there's something scary going on here.

Comment 3

[moz_bug_r_a4]

http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/extensions/content/extensions-content.js#175

175     checkLoadURIFromScript: function(aUri) {
176       var secman = Cc["@mozilla.org/scriptsecuritymanager;1"].
177                    getService(Ci.nsIScriptSecurityManager);
178       var principal = this.window.content.document.nodePrincipal;
179       try {
180         secman.checkLoadURIWithPrincipal(principal, aUri,
181           Ci.nsIScriptSecurityManager.DISALLOW_INHERIT_PRINCIPAL);
182         return true;
183       }
184       catch(e) {
185         return false;
186       }
187     }

principal is undefined here, since this.window is a SJOW, and thus
this.window.content.document is not a real document.

this.window being a SJOW is not good.  Please see bug 645699.

Comment 4

[Jesse Ruderman]

Does the patch in bug 645699 fix this bug?

Comment 5

[Daniel Veditz [:dveditz]]

If this isn't fixed by bug 645699 then it probably bounces back to mrbkap. But assigning to mossop for now.

Comment 6

[Dave Townsend [:mossop]]

This was fixed by bug 645699