644081 - Build failure on OSX: error trying to exec '/usr/libexec/gcc/i686-apple-darwin10/4.2.1/collect2': execv: Argument list too long

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Simon Montagu :smontagu]

Attachment: Output of expandlibs_exec.py --v

i686-apple-darwin10-g++-4.2.1: error trying to exec '/usr/libexec/gcc/i686-apple-darwin10/4.2.1/collect2': execv: Argument list too long

Comment 1

[Mike Hommey [:glandium]]

As per irc, using relative paths instead of absolute makes it work, so it's a command line length issue, and not an argument count issue.

The fix would be pretty simple if we'd require python 2.6, but we require python 2.5, which doesn't have os.path.relpath...

Comment 2

[Josh Aas]

Is there a workaround for this?

Comment 3

[Mike Hommey [:glandium]]

Attachment: quick and dirty workaround

Requires python 2.6

Comment 4

[Mike Hommey [:glandium]]

Attachment: Use relative paths as much as possible in expandlibs.py

Comment 5

[David :Bienvenu]

FWIW, the patch allows Thunderbird to build against trunk moz-central.

Comment 7

[(not currently active) Ted Mielczarek]

Comment on attachment 521472 [details] [diff] [review]
Use relative paths as much as possible in expandlibs.py

>+def relativize(path):

Can you stick a short docstring comment here? I gather that this produces a path relative to the current working directory, but it would be good to have that noted.

Looks fine otherwise. Do we get screwed on mac because of the old gcc version? I thought we were using linker scripts where possible.

Comment 8

[Mike Hommey [:glandium]]

(In reply to comment #7)
> Looks fine otherwise. Do we get screwed on mac because of the old gcc version?

yes

> I thought we were using linker scripts where possible.

we do, except mac is where it's not possible, because mac ld doesn't support link scripts.

Comment 9

[Mike Hommey [:glandium]]

http://hg.mozilla.org/mozilla-central/rev/208e88837e65

Comment 10

[Mike Hommey [:glandium]]

Attachment: Use relative paths as much as possible in expandlibs.py, as landed