644513 - Remove the presshell argument to nsEudoraEditor::Init as it's no longer necessary

Status: RESOLVED FIXED

(MailNews Core :: Import, defect)

Description

[Philip Chee]

This needs to be fixed on comm-central after it branches.

http://hg.mozilla.org/mozilla-central/rev/820c0e4e88db
Bug 407127 - Part 6: Remove the presshell argument to nsIEditor::Init as it's no longer necessary

Comment 1

[Philip Chee]

Fixed
Neil pushed http://hg.mozilla.org/comm-central/rev/c5792851ad63

Comment 2

[(no longer active)]

Hmm, what is nsEudoraEditor?  Does anybody use it?  I'll be breaking many of the editor APIs in the mid-term future, so I need to coordinate with downstream users of the API, if there are any...

Comment 3

[Mark Banner (:standard8)]

It is in some of our import code, I can't quite remember what it does, but its some sort of processing on import. Bienvenu may rememeber.

Comment 4

[David :Bienvenu]

Yes, eudora import (and to a lesser extend, Outlook import, iirc), uses a fake compose window to import message contents, and then exports the message from the compose window and saves *that* to the local message store - it allows the import code to create correctly structured mime messages, e.g., for messages with attachments.

Comment 5

[[e-mail]]

FYI, part of this fake compose window includes simulating the OutputToString and GetEmbeddedObjects methods on the editor.

Comment 6

[(no longer active)]

Well, I'm probably safe to assume that we have zero tests which cover this in comm-central.  ;-)  So, this is probably worth keeping in mind for Thunderbird QA!