Closed
Bug 644576
Opened 13 years ago
Closed 13 years ago
First row with no cells breaks painting of collapsed borders for the whole table
Categories
(Core :: Layout: Tables, defect, P1)
Tracking
()
RESOLVED
FIXED
mozilla5
People
(Reporter: colin.m.pickup, Assigned: bzbarsky)
References
()
Details
Attachments
(2 files)
211 bytes,
text/html
|
Details | |
3.24 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US) AppleWebKit/534.16 (KHTML, like Gecko) Chrome/10.0.648.151 Safari/534.16 Build Identifier: 4.0 Rather than collapsing borders such that they overlap, the borders disappear completely. After trial and error enabling and disabling other CSS rules, I found that the borders appeared again when I removed a rule that applies display: none to the th cells of the table. This problem doesn't happen if it is a td that is hidden, only a th elemnt, as far as I can tell (see the demonstration above; Reproducible: Always Steps to Reproduce: 1. Create a valid table with table, thead, tr, th, tbody, and td elemnts 2. Apply border-collapse:collapse to the table 3. Apply display: none to a th element in the table Actual Results: All borders disappear from all elements of the table, including around the table itself Expected Results: The borders collapse as usual and the th elements are hidden
Assignee | ||
Comment 1•13 years ago
|
||
Assignee | ||
Updated•13 years ago
|
Summary: border-collapse: collapse hides all borders when th cells are display: none → Firs row with no cells breaks painting of collapsed borders for the whole table
Assignee | ||
Updated•13 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
Assignee | ||
Updated•13 years ago
|
Summary: Firs row with no cells breaks painting of collapsed borders for the whole table → First row with no cells breaks painting of collapsed borders for the whole table
Assignee | ||
Comment 2•13 years ago
|
||
Colin, thanks for reporting this! roc, the idea here is that we don't want to decide we're at the end just because the first row that intersects the bc damage area has no cells in it. I considered writing this more like Next() also, but I _think_ all the sane cases would end up with a dead cell here, so this should be ok and we don't need to iterate the rows in the group. I think.
Attachment #521626 -
Flags: review?(roc)
Assignee | ||
Updated•13 years ago
|
Component: DOM: CSS Object Model → Layout: Tables
Priority: -- → P1
QA Contact: style-system → layout.tables
Whiteboard: [need review]
Attachment #521626 -
Flags: review?(roc) → review+
Assignee | ||
Updated•13 years ago
|
Whiteboard: [need review] → [need landing]
Assignee | ||
Updated•13 years ago
|
Assignee: nobody → bzbarsky
Assignee | ||
Comment 3•13 years ago
|
||
Pushed http://hg.mozilla.org/mozilla-central/rev/d9e063c5402d
Status: NEW → RESOLVED
Closed: 13 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [need landing]
Target Milestone: --- → mozilla2.2
You need to log in
before you can comment on or make changes to this bug.
Description
•