64473 - "Alert me before downloading an image" pref should be in its own 'paragraph'

Status: VERIFIED FIXED

(SeaMonkey :: General, enhancement)

Description

[Jesse Ruderman]

Same as bug 64171, but for the Images panel.  (64171 was for the Cookies panel.)

The "Alert me before downloading an image" pref is currently indented under 
the "Do not load any images" radio button.  That makes it seem like the value 
of the checkbox is only meaningful when "Do not load any images" is selected, 
but the opposite is true (it's only meaningful when any of the other radio 
buttons are selected).

Comment 1

[Håkan Waara]

Accepting.

Comment 2

[Håkan Waara]

Attachment: Patch - removes the indentings, places the "No images" radiobutton on the top, disables the checkbox if "No images" is selected.

Comment 3

[Håkan Waara]

Attachment: Patch update - removed a useless check per timeless

Comment 4

[Håkan Waara]

Attachment: Patch update - yet another minor change, made "warnAboutImagesBox" global per timeless

Comment 5

[Håkan Waara]

Attachment: Patch update - timeless' fault :P

Comment 6

[Håkan Waara]

Attachment: Patch update - this is as good as this patch gets, still timeless' fault, sorry for the spam.

Comment 7

[Håkan Waara]

r=timeless, via IRC

Comment 8

[Syd Logan]

sr=syd

Comment 9

[Peter "jag" Annema]

Attachment: [patch] slightly improved pref-images.xul and pref-cookies.xul

Comment 10

[Peter "jag" Annema]

This patch incorporates hwaara's patch and cleans up the code a bit more.

cc'ing blake for r=.

Comment 11

[timeless]

+      // Hide originating server option.
+      document.getElementById("accOrgImages").removeAttribute("hidden");
<jag> s/Hide/Show/ [for that function only]
r=timeless after that logical negation.

Comment 12

[Peter "jag" Annema]

I've got a new patch here which hides the separators just like the surrounding
content to make the panel look better when the pref (if ever?) is disabled. It
also uses a broadcaster, simplifying the code.

Comment 13

[Peter "jag" Annema]

Attachment: [patch] Last one I hope

Comment 14

[timeless]

r=timeless

Comment 15

[Ben Goodger (use ben at mozilla dot org for email)]

a=[e-mail]

Comment 16

[Peter "jag" Annema]

Fix checked in, marking fixed.

Comment 17

[[e-mail]]

Verfied, marking as verfied as well

OS: Win2k SP1
Moz Build: 2001012820 Win32 Talkback
User Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; m18) Gecko/20010128