Closed Bug 644871 Opened 9 years ago Closed 9 years ago
And Sweep/Mark And Sweep Compartment
These functions are mostly redundant and it happened to me more than once that I only changed one function...
Assignee: general → anygregor
Great! Let's get this in soon. One thing I noticed: when moving shapes to the GC heap, I forgot to take out the TIMESTAMP code for shape sweeping. It doesn't really time anything anymore. This might be a good opportunity to take it out.
(In reply to comment #2) > Great! Let's get this in soon. > > One thing I noticed: when moving shapes to the GC heap, I forgot to take out > the TIMESTAMP code for shape sweeping. It doesn't really time anything anymore. > This might be a good opportunity to take it out. We could still time the shape finalization if we move it out of finalizeObjectArenaLists. Brendan, is there some magic behind DumpLoopStats and DumpScopeDepthMeter? I can't find an implementation for them. Is it safe to remove?
I restored the shape-finalization timing again. Otherwise there shouldn't be any change to the previous code.
Now for real...
Comment on attachment 521882 [details] [diff] [review] patch Could you also take out the sentence about how "We finalize iterators before other objects..."? As far as I can tell, that's just not true any more.
Attachment #521882 - Flags: review?(wmccloskey) → review+
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.