Closed Bug 644871 Opened 9 years ago Closed 9 years ago

Combine MarkAndSweep/MarkAndSweepCompartment

Categories

(Core :: JavaScript Engine, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: gwagner, Assigned: gwagner)

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file, 3 obsolete files)

These functions are mostly redundant and it happened to me more than once that I only changed one function...
Attached patch patch (obsolete) — Splinter Review
Assignee: general → anygregor
Great! Let's get this in soon.

One thing I noticed: when moving shapes to the GC heap, I forgot to take out the TIMESTAMP code for shape sweeping. It doesn't really time anything anymore. This might be a good opportunity to take it out.
(In reply to comment #2)
> Great! Let's get this in soon.
> 
> One thing I noticed: when moving shapes to the GC heap, I forgot to take out
> the TIMESTAMP code for shape sweeping. It doesn't really time anything anymore.
> This might be a good opportunity to take it out.

We could still time the shape finalization if we move it out of finalizeObjectArenaLists.


Brendan, is there some magic behind DumpLoopStats and DumpScopeDepthMeter? I can't find an implementation for them. Is it safe to remove?
Attached patch patch (obsolete) — Splinter Review
Attachment #521701 - Attachment is obsolete: true
Attached patch patch (obsolete) — Splinter Review
I restored the shape-finalization timing again. 
Otherwise there shouldn't be any change to the previous code.
Attachment #521728 - Attachment is obsolete: true
Attachment #521868 - Flags: review?(wmccloskey)
Attached patch patchSplinter Review
Now for real...
Attachment #521868 - Attachment is obsolete: true
Attachment #521868 - Flags: review?(wmccloskey)
Attachment #521882 - Flags: review?(wmccloskey)
Comment on attachment 521882 [details] [diff] [review]
patch

Could you also take out the sentence about how "We finalize iterators before other objects..."? As far as I can tell, that's just not true any more.
Attachment #521882 - Flags: review?(wmccloskey) → review+
http://hg.mozilla.org/tracemonkey/rev/5c7a2ced20f8
Whiteboard: fixed-in-tracemonkey
http://hg.mozilla.org/mozilla-central/rev/5c7a2ced20f8
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.