644943 - When entered URL "net2mobiles" getting exceptions (NS_ERROR_FAILURE in nsHandlerService.js) in Error Console

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Sami]

User-Agent:       Mozilla/5.0 (Windows NT 5.1; rv:2.0) Gecko/20100101 Firefox/4.0
Build Identifier: File version. 2.2.0.4100

When i entered the URL "net2mobiles" in the fennec browser i found ERROR EXCEPTIONS in error console of fennec browser

For more information please view attachments

Thanks & Regards,
Sami Ahmed Shaik.

Reproducible: Always

Steps to Reproduce:
1. Enter the URL in the fennec browser (net2mobiles) and press [Enter] in the keyboard
2. Go to error console of fennec browser
3. Observe the application
Actual Results:  
I found ERROR EXCEPTIONS 

[Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIProperties.get]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: file:///C:/Documents%20and%20Settings/Raju/Desktop/Mozilla%20Stuff/fennec/components/nsHandlerService.js :: <TOP_LEVEL> :: line 909"  data: no]
file:///C:/Documents%20and%20Settings/Raju/Desktop/Mozilla%20Stuff/fennec/components/nsHandlerService.js
909"

Expected Results:  
Page should be open without any exceptions

Source:
Built from: http://hg.mozilla.org/mozilla-central/rev/868be4c08700

Build Platform:

target
i686-pc-mingw32

Comment 1

[Sami]

Attachment: Error Exception Screenshot in Error Console

Application Screenshot

Comment 2

[Ludovic Hirlimann [:Usul]]

Not a security issue - and doesn't need to stay hidden.

Comment 3

[Sami]

Is it a defect or can't resolved? I need a clear comment please.

Thanks,
Sami Shaik.

Comment 4

[Martijn Wargers (dead)]

I'm still seeing this on current trunk Windows build, when loading a local .js or .log file (and probably more). I don't see the error occuring on .htm or .txt files.

This is the error message:
[Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIProperties.get]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: file:///C:/Users/mw22/Desktop/moz/fennec_builds/2011/fennec20110413/components/nsHandlerService.js :: <TOP_LEVEL> :: line 909"  data: no]
file:///C:/Users/mw22/Desktop/moz/fennec_builds/2011/fennec20110413/components/nsHandlerService.js
909

Comment 5

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch

Comment 6

[Benjamin Smedberg]

Comment on attachment 529174 [details] [diff] [review]
patch

This doesn't look like the right place for these checks. If we really shouldn't ever be using the handler service in the content process, shouldn't be put the check in the service constructor?

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 529174 [details] [diff] [review]
patch

Yeah, I think Benjamin is right.

In any case, this patch clearly breaks the existing code, so r-.

Comment 8

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch

Comment 9

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 529527 [details] [diff] [review]
patch


>+const HandlerServiceFactory = {
>+  _instance: null,
>+  createInstance: function (outer, iid) {
>+    if (this._instance)
>+      return this._instance;
>+
>+    let processType = Components.classes["@mozilla.org/xre/runtime;1"].
>+      getService(Components.interfaces.nsIXULRuntime).processType;
>+    if (processType != Components.interfaces.nsIXULRuntime.PROCESS_TYPE_DEFAULT)
>+      return Components.results.NS_ERROR_NOT_IMPLEMENTED;
>+
>+    return (this._instance = new HandlerService());
>+  }
>+};

You have Cc, Ci and Cr available. Please use them.

Comment 10

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch

using Cc, Ci and Cr

Comment 11

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 529534 [details] [diff] [review]
patch

r=me

Comment 12

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 529534 [details] [diff] [review]
patch

>+    if (processType != Ci.nsIXULRuntime.PROCESS_TYPE_DEFAULT)
>+      return Cr.NS_ERROR_NOT_IMPLEMENTED;

throw?

Comment 13

[Brad Lassey [:blassey] (use needinfo?)]

(In reply to comment #12)
> Comment on attachment 529534 [details] [diff] [review] [review]
> patch
> 
> >+    if (processType != Ci.nsIXULRuntime.PROCESS_TYPE_DEFAULT)
> >+      return Cr.NS_ERROR_NOT_IMPLEMENTED;
> 
> throw?

the whole point of this is to prevent throwing. The previous patch (attempted) to prevent us from asking for the service where it's used, but the preference from bz and bsmedberg for doing it in the service constructor.

Comment 14

[Brad Lassey [:blassey] (use needinfo?)]

pushed http://hg.mozilla.org/mozilla-central/rev/7fdc7150c67c

Comment 15

[Andreea Pod]

Verified fixed on build: Mozilla /5.0 (Android;Linux armv7l;rv:6.0a1) Gecko/20110517 Firefox/6.0a1 Fennec/6.0a1
Device: LG Optimus 2X  (Android 2.2)