The default bug view has changed. See this FAQ.

Pass correct host triplet to libffi configure

RESOLVED FIXED

Status

()

Core
Build Config
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Jacek Caban, Assigned: Jacek Caban)

Tracking

Trunk
x86_64
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 521795 [details] [diff] [review]
fix v1.0

There is a special case added for mingw to js/src/configure.in that treats mingw differently for mingw in bug 538216 comment 32. It was needed back then. However mingw-w64 (a fork of mingw.org, unlike what name suggests, not win64-specific) uses proper triplet i686-w64-mingw32 in this case. We could improve special-case to detect only plain old mingw, but right now m-c compiles only with mingw-w64 and it is unlikely to change (esp. given that mingw-w64 replacing domination of plain mingw is a matter of time), so I propose to get rid of the special case at all.
Attachment #521795 - Flags: review?(ted.mielczarek)
Attachment #521795 - Flags: review?(ted.mielczarek) → review+
(Assignee)

Comment 1

6 years ago
Thanks for review, pushed to t-m:

http://hg.mozilla.org/tracemonkey/rev/408c30d4a038
Whiteboard: fixed-in-tracemonkey
(Assignee)

Comment 2

6 years ago
Merged to m-c:

http://hg.mozilla.org/mozilla-central/rev/408c30d4a038
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: fixed-in-tracemonkey
You need to log in before you can comment on or make changes to this bug.