645092 - Stop using [deprecated] Storage methods (testpilot)

Status: RESOLVED FIXED

(Mozilla Labs Graveyard :: Test Pilot, defect)

Description

[Shawn Wilsher :sdwilsh]

Attachment: v1.0

These are going away in bug 645049, so we need to update our code to the new
world order.

Comment 1

[Dave Townsend [:mossop]]

Looks ok to me however I don't think we're updating the in-tree version at this point. Jono should take this and land it in the main repo for the extension.

Comment 2

[Shawn Wilsher :sdwilsh]

Jono, can you clarify what needs to be done with this patch please?

Comment 3

[Jono Xia]

My only concern is whether this change breaks backwards compatibility with Firefox 3.6.  When was the new API introduced?

Comment 4

[Shawn Wilsher :sdwilsh]

The new API was introduced in 4.0 (albeit, very early in the cycle).  If this needs to work with 3.6 still, we can just change the call to stmt.params[index] = value which works all the way back to 3.5.

Comment 5

[Jono Xia]

Although I am looking forward to not having to support older versions, Jinghua and i had a discussion about dropping support for 3.6 and decided it wasn't time yet.

So is it OK to use stmt.params[index] = value?  There's no security concerns, or issues with getting an unwanted data type conversion?

Comment 6

[Shawn Wilsher :sdwilsh]

(In reply to comment #5)
> So is it OK to use stmt.params[index] = value?  There's no security concerns,
> or issues with getting an unwanted data type conversion?
You'll still want to do the string escaping there that you currently do, but otherwise it's identical (and syntactically nicer to use).  It's what I actually encourage JS consumers to do.

Comment 7

[Jono Xia]

Done in http://hg.mozilla.org/labs/testpilot/rev/50d150fa6116

Comment 8

[Jono Xia]

Attachment: Patch to mozilla-central to fix this bug

(This version of the patch uses the backwards-compatible API)

Comment 9

[Dave Townsend [:mossop]]

Landed on m-c as a part of http://hg.mozilla.org/mozilla-central/rev/f6152e382b94