645138 - setting tegra screen resolution via tools/sut_tools/config.py broken

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P3)

Description

[Aki Sasaki (not active)]

This breaks some tegra reftests.

Currently our workaround is to make this script a noop, as running it was causing badness of some sort.

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

I think we have height/width mixed up here:
https://hg.mozilla.org/build/tools/file/28dcc684794d/sut_tools/config.py#l89

x == width == 1680
y == height == 1050

at least that is what I saw while debugging this locally.

In addition, we need to make this script search for all reftest stuff:
https://hg.mozilla.org/build/tools/file/28dcc684794d/sut_tools/config.py#l106

maybe change this:
if testname.startswith('reftest') and width < refWidth:

to:
if re.match("^(js)?(crash|ref)test$", testname) and width < refWidth:

Comment 2

[Aki Sasaki (not active)]

Bob:

Today you said that we aren't planning on running any of these tests on device because it doesn't make sense.

How important is it that we run them on Tegra if we don't care about those tests on device?  If we are going to revisit those tests to get them to run in a different resolution, I vote we disable them now and turn them on when they're fixed.

Comment 3

[Bob Moss :bmoss]

Aki,

No what I said was these tests should be fixed to fit on the mobile form factor if they make sense, otherwise maybe we should write tests that do the right thing on mobile. If these tests make sense, imho we should do the workaround until they are fixed/replaced.

Comment 4

[cmtalbert]

(In reply to comment #2)
> Bob:
> 
> Today you said that we aren't planning on running any of these tests on device
> because it doesn't make sense.
> 
> How important is it that we run them on Tegra if we don't care about those
> tests on device?  If we are going to revisit those tests to get them to run in
> a different resolution, I vote we disable them now and turn them on when
> they're fixed.
The other reason we need these tests on tegras is that this is the only platform testing the E10S enabled layers code on ARM.  Until Reftest is fixed, it's the only platform that can run these tests.

Comment 5

[Mike Taylor [:bear]]

Attachment: changes to config.py to fix resolution setting

Comment 6

[Aki Sasaki (not active)]

Comment on attachment 523011 [details] [diff] [review]
changes to config.py to fix resolution setting

This looks good.

Comment 7

[Mike Taylor [:bear]]

Comment on attachment 523011 [details] [diff] [review]
changes to config.py to fix resolution setting

committed changeset 1315:e8baf75d973d

Comment 8

[Mike Taylor [:bear]]

running in production with no issues