645206 - Get rid of use_accel_key pref

Status: RESOLVED FIXED

(Cloud Services :: Share: Firefox Client, defect)

Description

[Philipp von Weitershausen [:philikon]]

I don't know of any other built-in feature that allows one to change the key code. That doesn't mean we can't do it, but I wonder if there are some UX/coding guidelines that dictate the keycode must be static. Also, we could remove a bunch of code if we just hardcoded it as "F1".

Comment 1

[Philipp von Weitershausen [:philikon]]

Never mind, I misread the code. The use_accel_key pref merely flips the accel key on and off. That in itself is a pretty good idea, just the code for it could use some cleaning up, so I'm morphing bug into that.

Comment 2

[Bryan Clark (DevTools PM) [:clarkbw]]

Sorry, I think I wrote that :)

Comment 3

[Philipp von Weitershausen [:philikon]]

So to move forward here, we need to know whether we're keeping the F1 shortcut and whether it should remain configurable or not. In either case I'm sure we can simplify the existing code, but that still hinges on what the UX decision is here. Bryan, can you find out?

Comment 4

[Bryan Clark (DevTools PM) [:clarkbw]]

(In reply to comment #3)
> So to move forward here, we need to know whether we're keeping the F1 shortcut
> and whether it should remain configurable or not. In either case I'm sure we
> can simplify the existing code, but that still hinges on what the UX decision
> is here. Bryan, can you find out?

Yes, just talked with the UX team and we'd like to keep the F1 key as the key binding.  We can remove the preference for using the F1 key or not, that might be in another bug.

Comment 5

[Philipp von Weitershausen [:philikon]]

(In reply to comment #4)
> Yes, just talked with the UX team and we'd like to keep the F1 key as the key
> binding.  We can remove the preference for using the F1 key or not, that might
> be in another bug.

Well, that decision kinda influences what happens in this bug, so we should just make that call here.

Comment 6

[Bryan Clark (DevTools PM) [:clarkbw]]

(In reply to comment #5)
> (In reply to comment #4)
> > Yes, just talked with the UX team and we'd like to keep the F1 key as the key
> > binding.  We can remove the preference for using the F1 key or not, that might
> > be in another bug.
> 
> Well, that decision kinda influences what happens in this bug, so we should
> just make that call here.

Sorry, mistyped what I wanted to say there.  We can remove the F1 key-binding preference; signed off.  I'm not sure if you want to open another bug for removing the preference.

Comment 7

[Philipp von Weitershausen [:philikon]]

(In reply to comment #6)
> Sorry, mistyped what I wanted to say there.  We can remove the F1 key-binding
> preference; signed off.  I'm not sure if you want to open another bug for
> removing the preference.

Nope, morphing this bug into that.

Comment 8

[Philipp von Weitershausen [:philikon]]

Attachment: v1

Comment 9

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 523355 [details] [diff] [review]
v1

removing code is fun, I'd r=+2 if I could :)

Comment 10

[Philipp von Weitershausen [:philikon]]

https://hg.mozilla.org/users/pweitershausen_mozilla.com/fx-share/rev/89a2d8f39c60