64541 - Change xpcomproxy contractid to xpcom/proxy contractid

Status: RESOLVED WONTFIX

(Core :: XPCOM, defect)

Description

[Marco Bosch]

xpcom/proxy/public/nsIProxyObjectManager.idl defines NS_XPCOMPROXY_CONTRACTID as
"@mozilla.org/xpcomproxy;1". I think it would be better to change this to
"@mozilla.org/xpcom/proxy;1". This would better follow the contractID rules,
which suggest a modules/submodule structure. The only users in the Mozilla
codebase of this contractid are all in the same file:

/directory/xpcom/base/src/nsLDAPChannel.cpp, line 104 --
do_GetService("@mozilla.org/xpcomproxy;1", &rv);
/directory/xpcom/base/src/nsLDAPChannel.cpp, line 462 --
do_GetService("@mozilla.org/xpcomproxy;1", &rv);
/directory/xpcom/base/src/nsLDAPChannel.cpp, line 529 --
do_GetService("@mozilla.org/xpcomproxy;1", &rv);

So it seems like a four character / 2 files change....

Comment 1

[Keyser Sose]

Marking NEW so someone who more experience can look at it.

Comment 2

[Scott Collins]

Ray?  Is this appropriate?

Comment 3

[Ray Whitmer]

This name change seems appropriate from a logical perspective.

Having changed a few contractid's before, it is sound advice to look in lxr for
references.  lxr lists several additional places that this CONTRACTID is used,
and at least one of those (nsLDAPDataSource.js) does not use the .h file
definition.  We should first be confident that this change does not break
external users, especially who may have written .js scripts.  It was used by
nsLDAPDataSource to add an observer to a datasource.  Netscape 6 is one such
external user that might have used it that should be checked.

Comment 4

[Ray Whitmer]

Reassigning to default xpcom owner

Comment 5

[Doug Turner (:dougt)]

Apply a tested patch if you strongly want to see this changed.

Comment 6

[Doug Turner (:dougt)]

xpcom proxy code is not frozen nor will be for mozilla 1.0

Comment 7

[Doug Turner (:dougt)]

removing keyword

Comment 8

[Doug Turner (:dougt)]

this is *not* part of any SDK.  and therefore should not be a topembed.

Comment 9

[Jaime Rodriguez, Jr.]

Confirming this bug as topembed- for 1.3 triage.