645433 - Bugzilla->error_mode( ERROR_MODE_WEBPAGE ) doesn't change Bugzilla->error_mode

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect)

Description

[Yavor Nikolov]

User-Agent:       Mozilla/5.0 (Windows NT 6.0; rv:2.0) Gecko/20100101 Firefox/4.0
Build Identifier: 4.1.1

This is very similar to bug #645427

sub error_mode {
...
    return $class->request_cache->{error_mode}
        || (i_am_cgi() ? ERROR_MODE_WEBPAGE : ERROR_MODE_DIE);
}

With ERROR_MODE_WEBPAGE the above return always ignores first part of the || expression because ERROR_MODE_WEBPAGE == 0.

Reproducible: Always

Steps to Reproduce:
From console app run Bugzilla->usage_mode( USAGE_MODE_BROWSER ) - this also attempts to change error_mode
Actual Results:  
Bugzilla->error_mode( ERROR_MODE_WEBPAGE ) doesn't change Bugzilla->usage_mode to ERROR_MODE_WEBPAGE

Expected Results:  
Bugzilla->error_mode( ERROR_MODE_WEBPAGE ) should change Bugzilla->usage_mode to ERROR_MODE_WEBPAGE

Comment 1

[Yavor Nikolov]

In Expected/Actual Results of problem description Bugzilla->usage_mode should be read as Bugzilla->error_mode.

Comment 2

[Frédéric Buclin]

We should check "exists $class->request_cache->{error_mode}".

Comment 3

[Koosha KM]

Attachment: V1

The return statement in the 'else' part could also be written without the 'else'. That is outside the last if.

Comment 4

[Frédéric Buclin]

Comment on attachment 617199 [details] [diff] [review]
V1

>-    return $class->request_cache->{error_mode}
>-        || (i_am_cgi() ? ERROR_MODE_WEBPAGE : ERROR_MODE_DIE);
>+    if (exists($class->request_cache->{error_mode}) {

There is a missing closing parenthesis.


>+        return $class->request_cache->{error_mode};
>+    }
>+    else {
>+        return (i_am_cgi() ? ERROR_MODE_WEBPAGE : ERROR_MODE_DIE);
>+    }

As for bug 645427, I will add a comment about making the code cleaner once we require Perl 5.10.1. r=LpSolit

Comment 5

[Frédéric Buclin]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified Bugzilla.pm
Committed revision 8214.