Closed
Bug 645437
Opened 13 years ago
Closed 13 years ago
Allow setting the revision in an hgPoller to a specific build property.
Categories
(Release Engineering :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: Callek, Assigned: Callek)
References
Details
Attachments
(2 files, 1 obsolete file)
798 bytes,
patch
|
kairo
:
review+
catlee
:
feedback+
Callek
:
checked-in+
|
Details | Diff | Splinter Review |
2.31 KB,
patch
|
catlee
:
review+
Callek
:
checked-in+
|
Details | Diff | Splinter Review |
While tackling Bug 643324 it occurs to me that the way the comm-central apps use the HgPoller is suboptimal. It unilaterally sets |revision| to whatever is found in the repo we are actually polling. I think we should allow the revision as discovered by the HgPoller to set a property on the build itself, so that our resulting build can identify this and utilize it properly.
Assignee | ||
Updated•13 years ago
|
Assignee: nobody → bugspam.Callek
Assignee | ||
Comment 1•13 years ago
|
||
I am relying on a few assumptions about how merging works when this is employed. Presuming that property1 is overwritten by a newer property1 in a newer changesource. Also hoping that my assumption about if there is a property1 set from one poll, and a property2 set from another poll and the builds merge, that we are left with BOTH a property1 and a property2 on the resulting build. (If not, I am not as worried; but would prefer it that way). Any confirmation on my assumptions will be helpful, as well as a brief bit of time to let this run on preproduction, for sanity sake.
Attachment #522175 -
Flags: review?(catlee)
Assignee | ||
Comment 2•13 years ago
|
||
Comment on attachment 522175 [details] [diff] [review] HgPoller Change ...got the idea for this from the l10n poller, by the way.
Assignee | ||
Comment 3•13 years ago
|
||
Attachment #522176 -
Flags: review?(kairo)
Assignee | ||
Updated•13 years ago
|
Attachment #522176 -
Flags: feedback?(catlee)
Comment 4•13 years ago
|
||
Comment on attachment 522175 [details] [diff] [review] HgPoller Change I think storeRev needs to be added to compare_attrs. It also needs to be stored to self.storeRev in __init__. Looks good otherwise!
Attachment #522175 -
Flags: review?(catlee) → review-
Updated•13 years ago
|
Attachment #522176 -
Flags: feedback?(catlee) → feedback+
Assignee | ||
Comment 5•13 years ago
|
||
After looking at what compare_attrs does, I think adding these other overlooked things to it is probably useful as well (I can drop them entirely if you like) [No idea how I missed setting self.storeRev though in v1]
Attachment #522175 -
Attachment is obsolete: true
Attachment #522555 -
Flags: review?(catlee)
Comment 6•13 years ago
|
||
Comment on attachment 522555 [details] [diff] [review] HgPoller Change v2 One last thought...do we need to call the parent's changeHook?
Updated•13 years ago
|
Attachment #522555 -
Flags: review?(catlee) → review+
Assignee | ||
Comment 7•13 years ago
|
||
Comment on attachment 522555 [details] [diff] [review] HgPoller Change v2 Pushed to default/pre-production.
Attachment #522555 -
Flags: checked-in+
Updated•13 years ago
|
Attachment #522176 -
Flags: review?(kairo) → review+
Assignee | ||
Updated•13 years ago
|
Attachment #522176 -
Flags: checked-in+
Assignee | ||
Comment 8•13 years ago
|
||
Deployed to production SeaMonkey, and no fallout in mozilla preproduction. resolving. Will get my answers to c#1 tomorrow when there is more traffic.
Assignee | ||
Updated•13 years ago
|
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Product: mozilla.org → Release Engineering
You need to log in
before you can comment on or make changes to this bug.
Description
•