645460 - Default to 32-bit NSS builds on OS X 10.6 (Snow Leopard) and later, too

Status: RESOLVED FIXED

(NSS :: Build, defect, P2)

Description

[Kaspar]

Attachment: Proposed patch

According to https://developer.mozilla.org/en/NSS_reference/Building_and_installing_NSS/Build_instructions:

> On platforms that support both 32-bit and 64-bit ABIs, tells NSS
> to build for the 64-bit ABI. Default is 32-bit ABI, except on platforms
> that do not support a 32-bit ABI.

With OS X 10.6 (Snow Leopard), Apple changed the default architecture for gcc to x86_64.

The attached patch (to security/coreconf/Darwin.mk) makes sure that the OS X build continues to default to 32 bit, by adding the "-arch i386" option. For the sake of consistency, I suggest applying a similar option for ppc, while we're at it.

This depends on the companion NSPR bug 645459.

Comment 1

[Robert Relyea]

Comment on attachment 522180 [details] [diff] [review]
Proposed patch

r+ rrelyea

Kasper do you have checkin permission to NSS or do you need me to check this in?

bob

Comment 2

[Kaspar]

(In reply to comment #1)
> do you need me to check this in?

Yes, please - I don't have commit privileges.

Comment 3

[Wan-Teh Chang]

Comment on attachment 522180 [details] [diff] [review]
Proposed patch

r=wtc.

Patch checked in on the NSS trunk (NSS 3.13) and
NSS_3_12_BRANCH (NSS 3.12.10).

Checking in Darwin.mk;
/cvsroot/mozilla/security/coreconf/Darwin.mk,v  <--  Darwin.mk
new revision: 1.29; previous revision: 1.28
done

Checking in Darwin.mk;
/cvsroot/mozilla/security/coreconf/Darwin.mk,v  <--  Darwin.mk
new revision: 1.24.2.3; previous revision: 1.24.2.2
done