Closed Bug 645503 Opened 13 years ago Closed 13 years ago

Port Bug 599909 [to-be-reloaded tabs don't show up in switch-to-tab]

Categories

(SeaMonkey :: Session Restore, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.1b3

People

(Reporter: misak.bugzilla, Assigned: misak.bugzilla)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch patch with failing test (obsolete) — Splinter Review
From parent bug:

ithinc pointed out that we never set currentURI on the browser until a tab is
actually restored (bug 597757 comment 17). This is at least partially
responsible for hiding those tabs from switch-to-tab (switchToTabHavingURI
looks at browser.currentURI).

Setting currentURI as ithinc suggested should fix that problem, but it might
not add the tab to matches as you search. I'm not sure where the urlbar looks
for matching tabs, so there might be something additional to do there.

For _most_ people this won't be an issue, but for people on slow connections or
people who have tweaked some prefs, it does become an issue (set
browser.sessionstore.max_concurrent_tabs = 0 :/)


This patch helps me find bug in test for bug 607016 - i fixed it here too. The patch is OK, except the test - i need the suggestion how to rewrite it or disable. It failing currently, so just requesting feedback.
Attachment #522221 - Flags: feedback?(neil)
Comment on attachment 522221 [details] [diff] [review]
patch with failing test

Code change looks OK but test requires switch-to-tab which we don't have (yet)
Attachment #522221 - Flags: feedback?(neil) → feedback+
Attached patch patchSplinter Review
This is same patch as above, but without test.
Attachment #522221 - Attachment is obsolete: true
Attachment #523549 - Flags: review?(neil)
Attachment #523549 - Flags: review?(neil) → review+
Pushed: http://hg.mozilla.org/comm-central/rev/782a4c7cf7c0
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Flags: in-testsuite+
Target Milestone: --- → seamonkey2.1b3
You need to log in before you can comment on or make changes to this bug.