645538 - when starting Firefox, a bunch of WARNING: Subdocument container has no content: file layout/base/nsDocumentViewer.cpp, line 2401

Status: RESOLVED FIXED

(Core :: Layout, defect, P2)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

When starting up Firefox, I see multiple occurrences of:

WARNING: Subdocument container has no content: file /home/dbaron/builds/ssd/mozilla-central/mozilla/layout/base/nsDocumentViewer.cpp, line 2401


Either (a) this is a serious problem and we should fix it or (b) it's not something we need to print information about to everybody.


The stack of the first of these warnings is:

#0  NS_DebugBreak_P (aSeverity=0, 
    aStr=0x7ffff69fe838 "Subdocument container has no content", aExpr=0x0, 
    aFile=0x7ffff69fdbf8 "/home/dbaron/builds/ssd/mozilla-central/mozilla/layout/base/nsDocumentViewer.cpp", aLine=2401)
    at /home/dbaron/builds/ssd/mozilla-central/mozilla/xpcom/base/nsDebugImpl.cpp:264
#1  0x00007ffff4b6ac1e in DocumentViewerImpl::FindContainerView (
    this=<value optimized out>)
    at /home/dbaron/builds/ssd/mozilla-central/mozilla/layout/base/nsDocumentViewer.cpp:2401
#2  0x00007ffff4b62adf in DocumentViewerImpl::InitInternal (this=0xce0a90, 
    aParentWidget=<value optimized out>, aState=<value optimized out>, 
    aBounds=..., aDoCreation=1, aNeedMakeCX=<value optimized out>, 
    aForceSetNewDocument=1)
    at /home/dbaron/builds/ssd/mozilla-central/mozilla/layout/base/nsDocumentViewer.cpp:872
#3  0x00007ffff4b63491 in DocumentViewerImpl::Init (this=0x0, 
    aParentWidget=0x7ffff69fe838, aBounds=<value optimized out>)
    at /home/dbaron/builds/ssd/mozilla-central/mozilla/layout/base/nsDocumentViewer.cpp:709
#4  0x00007ffff5a9ac18 in nsDocShell::SetupNewViewer (this=0xcd6200, 
    aNewViewer=0x0)
    at /home/dbaron/builds/ssd/mozilla-central/mozilla/docshell/base/nsDocShell.cpp:7733
#5  0x00007ffff5a866e4 in nsDocShell::Embed (this=0xcd6200, 
    aContentViewer=0xce0a90, aCommand=<value optimized out>, 
    aExtraInfo=<value optimized out>)
    at /home/dbaron/builds/ssd/mozilla-central/mozilla/docshell/base/nsDocShell.cpp:5776
#6  0x00007ffff5a91275 in nsDocShell::CreateAboutBlankContentViewer (
    this=0xcd6200, aPrincipal=<value optimized out>, 
    aBaseURI=<value optimized out>, 
    aTryToSaveOldPresentation=<value optimized out>)
    at /home/dbaron/builds/ssd/mozilla-central/mozilla/docshell/base/nsDocShell.cpp:6551
#7  0x00007ffff5a97540 in nsDocShell::EnsureContentViewer (this=0xcd6200)
    at /home/dbaron/builds/ssd/mozilla-central/mozilla/docshell/base/nsDocShell.cpp:6457
#8  0x00007ffff5a80eba in nsDocShell::GetInterface (this=0xcd6200, aIID=..., 
    aSink=0x7fffffffa1d8)
    at /home/dbaron/builds/ssd/mozilla-central/mozilla/docshell/base/nsDocShell.cpp:895
#9  0x00007ffff61dae05 in nsGetInterface::operator() (this=0x7fffffffa1c0, 
    aIID=..., aInstancePtr=0x7fffffffa1d8)
    at nsIInterfaceRequestorUtils.cpp:52
#10 0x00007ffff5323ac4 in nsCOMPtr<nsIDOMDocument>::assign_from_helper (
    this=0xcd73a0, aDocument=0x7fffffffa240)
    at ../../dist/include/nsCOMPtr.h:1272
#11 nsCOMPtr (this=0xcd73a0, aDocument=0x7fffffffa240)
    at ../../dist/include/nsCOMPtr.h:644
#12 nsGlobalWindow::GetDocument (this=0xcd73a0, aDocument=0x7fffffffa240)
    at /home/dbaron/builds/ssd/mozilla-central/mozilla/dom/base/nsGlobalWindow.cpp:2885
#13 0x00007ffff5374110 in nsPIDOMWindow::EnsureInnerWindow (
    this=<value optimized out>, nativeObj=0xcd7418, cx=<value optimized out>, 
    globalObj=<value optimized out>, parentObj=0x7fffffffa290)
    at ../../dist/include/nsPIDOMWindow.h:342
#14 nsWindowSH::PreCreate (this=<value optimized out>, nativeObj=0xcd7418, 
    cx=<value optimized out>, globalObj=<value optimized out>, 
    parentObj=0x7fffffffa290)
    at /home/dbaron/builds/ssd/mozilla-central/mozilla/dom/base/nsDOMClassInfo.cpp:5043
#15 0x00007ffff5994ebb in ConstructProxyObject (ccx=..., aHelper=..., 
    xpcscope=<value optimized out>)
    at /home/dbaron/builds/ssd/mozilla-central/mozilla/js/src/xpconnect/src/xpcwrappednative.cpp:3937
#16 0x00007ffff596027e in XPCConvert::NativeInterface2JSObject (lccx=..., 
    d=<value optimized out>, dest=0x0, aHelper=..., 
    iid=<value optimized out>, Interface=<value optimized out>, 
    allowNativeWrapper=1, isGlobal=0, pErr=0x0)
    at /home/dbaron/builds/ssd/mozilla-central/mozilla/js/src/xpconnect/src/xpcconvert.cpp:1171
#17 0x00007ffff5960ac1 in XPCConvert::NativeData2JS (lccx=..., 
    d=0x7fffffffa750, s=<value optimized out>, type=..., 
    iid=<value optimized out>, pErr=0x0)
    at /home/dbaron/builds/ssd/mozilla-central/mozilla/js/src/xpconnect/src/xpcconvert.cpp:485
#18 0x00007ffff5988ebc in XPCConvert::NativeData2JS (
    this=<value optimized out>, wrapper=<value optimized out>, 
    methodIndex=<value optimized out>, info=0x755ec0, 
    nativeParams=<value optimized out>)
    at /home/dbaron/builds/ssd/mozilla-central/mozilla/js/src/xpconnect/src/xpcprivate.h:3257
#19 nsXPCWrappedJSClass::CallMethod (this=<value optimized out>, 
    wrapper=<value optimized out>, methodIndex=<value optimized out>, 
    info=0x755ec0, nativeParams=<value optimized out>)
    at /home/dbaron/builds/ssd/mozilla-central/mozilla/js/src/xpconnect/src/xpcwrappedjsclass.cpp:1565
#20 0x00007ffff597dde7 in nsXPCWrappedJS::CallMethod (this=0x7fffe009f120, 
    methodIndex=0, info=0x755ec0, params=0x7fffffffab10)
    at /home/dbaron/builds/ssd/mozilla-central/mozilla/js/src/xpconnect/src/xpcwrappedjs.cpp:588
#21 0x00007ffff628d4f0 in PrepareAndDispatch (self=<value optimized out>, 
    methodIndex=<value optimized out>, args=0x7fffffffac90, 
    gpregs=<value optimized out>, fpregs=<value optimized out>)
    at /home/dbaron/builds/ssd/mozilla-central/mozilla/xpcom/reflect/xptcall/src/md/unix/xptcstubs_x86_64_linux.cpp:153
#22 0x00007ffff628c81b in SharedStub () from ./libxul.so
#23 0x00007ffff620b395 in nsObserverList::NotifyObservers (
    this=<value optimized out>, aSubject=0xcd7418, 
    aTopic=0x7ffff6b0e62a "domwindowopened", someData=0x0)
    at /home/dbaron/builds/ssd/mozilla-central/mozilla/xpcom/ds/nsObserverList.cpp:130
#24 0x00007ffff620beb7 in nsObserverService::NotifyObservers (this=0x7958a0, 
    aSubject=0xcd7418, aTopic=0x7ffff6b0e62a "domwindowopened", someData=0x0)
    at /home/dbaron/builds/ssd/mozilla-central/mozilla/xpcom/ds/nsObserverService.cpp:182
#25 0x00007ffff5b1947f in nsWindowWatcher::AddWindow (
    this=<value optimized out>, aWindow=0xcd73a0, aChrome=0x0)
    at /home/dbaron/builds/ssd/mozilla-central/mozilla/embedding/components/windowwatcher/src/nsWindowWatcher.cpp:1206
#26 0x00007ffff5b87c26 in nsAppShellService::RegisterTopLevelWindow (
    this=<value optimized out>, aWindow=0xcd48c0)
    at /home/dbaron/builds/ssd/mozilla-central/mozilla/xpfe/appshell/src/nsAppShellService.cpp:555
#27 0x00007ffff5b88827 in nsAppShellService::CreateTopLevelWindow (
    this=0x6096b0, aParent=0x0, aUrl=<value optimized out>, 
    aChromeMask=2147487742, aInitialWidth=<value optimized out>, 
    aInitialHeight=<value optimized out>, aAppShell=0x6e4fe0, 
    aResult=0x7fffffffafc0)
    at /home/dbaron/builds/ssd/mozilla-central/mozilla/xpfe/appshell/src/nsAppShellService.cpp:235
#28 0x00007ffff5bac125 in nsAppStartup::CreateChromeWindow2 (this=0x94d0d0, 
    aParent=<value optimized out>, aChromeFlags=2147487742, 
    aContextFlags=<value optimized out>, aURI=<value optimized out>, 
    aCancel=<value optimized out>, _retval=0x7fffffffb370)
    at /home/dbaron/builds/ssd/mozilla-central/mozilla/toolkit/components/startup/nsAppStartup.cpp:508
#29 0x00007ffff5b1d90c in nsWindowWatcher::OpenWindowJSInternal (
    this=<value optimized out>, aParent=0x0, aUrl=<value optimized out>, 
    aName=<value optimized out>, aFeatures=<value optimized out>, 
    aDialog=<value optimized out>, argv=0xac5570, aCalledFromJS=0, 
    _retval=0x7fffffffbd38)
    at /home/dbaron/builds/ssd/mozilla-central/mozilla/embedding/components/windowwatcher/src/nsWindowWatcher.cpp:726
#30 0x00007ffff5b1ea13 in nsWindowWatcher::OpenWindow (
    this=<value optimized out>, aParent=0x0, 
    aUrl=0xac5510 "chrome://browser/content/", aName=0xac5d90 "_blank", 
    aFeatures=0xac5380 "chrome,dialog=no,all", aArguments=0xb662f0, 
    _retval=0x7fffffffbd38)
    at /home/dbaron/builds/ssd/mozilla-central/mozilla/embedding/components/windowwatcher/src/nsWindowWatcher.cpp:423
#31 0x00007ffff628c6a6 in NS_InvokeByIndex_P (that=<value optimized out>, 
    methodIndex=<value optimized out>, paramCount=<value optimized out>, 
    params=<value optimized out>)
    at /home/dbaron/builds/ssd/mozilla-central/mozilla/xpcom/reflect/xptcall/src/md/unix/xptcinvoke_x86_64_unix.cpp:195
#32 0x00007ffff599a052 in CallMethodHelper::Invoke (this=0x7fffffffbc80)
    at /home/dbaron/builds/ssd/mozilla-central/mozilla/js/src/xpconnect/src/xpcwrappednative.cpp:3136
#33 CallMethodHelper::Call (this=0x7fffffffbc80)
    at /home/dbaron/builds/ssd/mozilla-central/mozilla/js/src/xpconnect/src/xpcwrappednative.cpp:2402
#34 0x00007ffff599534c in XPCWrappedNative::CallMethod (ccx=..., 
    mode=<value optimized out>)
    at /home/dbaron/builds/ssd/mozilla-central/mozilla/js/src/xpconnect/src/xpcwrappednative.cpp:2366
#35 0x00007ffff59a3b24 in XPC_WN_CallMethod (cx=0x970d30, argc=5, 
    vp=<value optimized out>)
    at /home/dbaron/builds/ssd/mozilla-central/mozilla/js/src/xpconnect/src/xpcwrappednativejsops.cpp:1613
#36 0x00007ffff68a8c3d in CallJSNative (cx=0x970d30, 
    entryFrame=<value optimized out>, inlineCallCount=1, 
    interpMode=<value optimized out>)
    at /home/dbaron/builds/ssd/mozilla-central/mozilla/js/src/jscntxtinlines.h:701
#37 js::Interpret (cx=0x970d30, entryFrame=<value optimized out>, 
    inlineCallCount=1, interpMode=<value optimized out>)
    at /home/dbaron/builds/ssd/mozilla-central/mozilla/js/src/jsinterp.cpp:4799
#38 0x00007ffff6637c70 in js::RunScript (cx=0x970d30, script=0xcd0270, 
    fp=0x7fffdebfe050)
    at /home/dbaron/builds/ssd/mozilla-central/mozilla/js/src/jsinterp.cpp:653
#39 0x00007ffff6638129 in js::Invoke (cx=0x970d30, 
    argsRef=<value optimized out>, flags=0)
    at /home/dbaron/builds/ssd/mozilla-central/mozilla/js/src/jsinterp.cpp:740
#40 0x00007ffff66389a5 in js::ExternalInvoke (cx=0x970d30, thisv=..., 
    fval=..., argc=1, argv=0x7fffffffcf08, rval=<value optimized out>)
    at /home/dbaron/builds/ssd/mozilla-central/mozilla/js/src/jsinterp.cpp:863
#41 0x00007ffff65830b1 in JS_CallFunctionValue (cx=0x970d30, 
    obj=0x7fffdc933548, fval=..., argc=1, argv=0x7fffffffcf08, 
    rval=0x7fffffffcd20)
    at /home/dbaron/builds/ssd/mozilla-central/mozilla/js/src/jsapi.cpp:5173
#42 0x00007ffff5988354 in nsXPCWrappedJSClass::CallMethod (this=0xb5c0c0, 
    wrapper=<value optimized out>, methodIndex=<value optimized out>, 
    info=0x86f688, nativeParams=<value optimized out>)
    at /home/dbaron/builds/ssd/mozilla-central/mozilla/js/src/xpconnect/src/xpcwrappedjsclass.cpp:1672
#43 0x00007ffff597dde7 in nsXPCWrappedJS::CallMethod (this=0xc423b0, 
    methodIndex=0, info=0x86f688, params=0x7fffffffd070)
    at /home/dbaron/builds/ssd/mozilla-central/mozilla/js/src/xpconnect/src/xpcwrappedjs.cpp:588
#44 0x00007ffff628d4f0 in PrepareAndDispatch (self=<value optimized out>, 
    methodIndex=<value optimized out>, args=0x7fffffffd1f0, 
    gpregs=<value optimized out>, fpregs=<value optimized out>)
    at /home/dbaron/builds/ssd/mozilla-central/mozilla/xpcom/reflect/xptcall/src/md/unix/xptcstubs_x86_64_linux.cpp:153
#45 0x00007ffff628c81b in SharedStub () from ./libxul.so
#46 0x00007ffff5b9fbe0 in nsCommandLine::EnumerateHandlers (
    this=<value optimized out>, aCallback=<value optimized out>, 
    aClosure=<value optimized out>)
    at /home/dbaron/builds/ssd/mozilla-central/mozilla/toolkit/components/commandlines/nsCommandLine.cpp:592
#47 0x00007ffff5ba031e in nsCommandLine::Run (this=<value optimized out>)
    at /home/dbaron/builds/ssd/mozilla-central/mozilla/toolkit/components/commandlines/nsCommandLine.cpp:666
#48 0x00007ffff484eff7 in XRE_main (argc=<value optimized out>, 
    argv=<value optimized out>, aAppData=<value optimized out>)
    at /home/dbaron/builds/ssd/mozilla-central/mozilla/toolkit/xre/nsAppRunner.cpp:3739
#49 0x0000000000400f6c in main (argc=4, argv=0x7fffffffde68)
    at /home/dbaron/builds/ssd/mozilla-central/mozilla/browser/app/nsBrowserApp.cpp:158

Comment 1

[Boris Zbarsky [:bzbarsky]]

During startup this warning is certainly bogus: FindContainerView() is called unconditionally in InitInternal() and in this case we're initializing the doc viewer for the root document, so there is certainly containing content.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Remove bogus warning.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Er, so there is certainly _no_ containing content, and isn't expected to be any!

Comment 4

[Boris Zbarsky [:bzbarsky]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/29f857ce7e31

Comment 5

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/29f857ce7e31