Last Comment Bug 645581 - Dialog prompts to save from Text Editor should not be "Export as Text"
: Dialog prompts to save from Text Editor should not be "Export as Text"
Status: RESOLVED FIXED
:
Product: SeaMonkey
Classification: Client Software
Component: Composer (show other bugs)
: Trunk
: All All
: -- normal (vote)
: seamonkey2.1b3
Assigned To: Ian Neal
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-03-27 17:44 PDT by Ian Neal
Modified: 2011-03-28 16:26 PDT (History)
1 user (show)
iann_bugzilla: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Text Editor Save patch v1.0 [Checked in: Comments 2 & 3] (3.01 KB, patch)
2011-03-27 17:44 PDT, Ian Neal
neil: review+
Details | Diff | Splinter Review

Description Ian Neal 2011-03-27 17:44:22 PDT
Created attachment 522263 [details] [diff] [review]
Text Editor Save patch v1.0 [Checked in: Comments 2 & 3]

When you try save from the Text Editor, the dialog has a title of "Export as Text", it would probably be better as "Save Text As" or similar.

Also should check if we're in an HTML Editor before calling FinishHTMLSource function.

This patch fixes both these issues.
Comment 1 neil@parkwaycc.co.uk 2011-03-28 05:19:53 PDT
Comment on attachment 522263 [details] [diff] [review]
Text Editor Save patch v1.0 [Checked in: Comments 2 & 3]

(Unrelated to this patch, I notice that saving the initially blank document in the text editor still offers to save in HTML...)
Comment 2 Ian Neal 2011-03-28 14:42:15 PDT
Comment on attachment 522263 [details] [diff] [review]
Text Editor Save patch v1.0 [Checked in: Comments 2 & 3]

http://hg.mozilla.org/comm-central/rev/edb9543af082
Comment 3 Ian Neal 2011-03-28 16:25:44 PDT
Fixed typo http://hg.mozilla.org/comm-central/rev/57fe01890559

Note You need to log in before you can comment on or make changes to this bug.