645608 - If FF Window is minimized and restarted, the window is minimized/maximized then restored

Status: RESOLVED FIXED

(Firefox :: Session Restore, defect)

Description

[Cpuroast]

User-Agent:       Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0) Gecko/20100101 Firefox/4.0
Build Identifier: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0) Gecko/20100101 Firefox/4.0

If a Firefox window is in a minimized state when Firefox is quit. The next time Firefox is launched the window will go through a quick and odd minimize/restore sequence.

Reproducible: Always

Steps to Reproduce:
1.Minimize a Window
2.Quit Firefox
3.Re-launch Firefox
Actual Results:  
On re-launch the Window goes through a quick and odd minimize/restore sequence.

Expected Results:  
On re-launch the window is restored without being minimized first.

Comment 1

[Teodosia Pop]

Able to reproduce using  Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0)
Gecko/20100101 Firefox/4.0 but only if "When Firefox starts" from Preferences->General is set to "Show my windows and tabs from last time".

Comment 2

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Is it safe to assume that you only have one Firefox window open at the time?

Comment 3

[Cpuroast]

Yup just 1 window, 

behavior is still present in Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:5.0) Gecko/20100101 Firefox/5.0

Comment 4

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Attachment: Patch v0.1

Simple fix.

Comment 5

[Dietrich Ayala (:dietrich)]

Comment on attachment 548957 [details] [diff] [review]
Patch v0.1

Review of attachment 548957 [details] [diff] [review]:
-----------------------------------------------------------------

Not sure it's possible to reasonably write a test for this, so please flag for manual testing. r=me.

::: browser/components/sessionstore/src/nsSessionStore.js
@@ +352,5 @@
>            this._sessionStartTime = this._initialState.session &&
>                                     this._initialState.session.startTime ||
>                                     this._sessionStartTime;
>  
> +          let firstWindow = this._initialState.windows[0];

Actually, I liked it without the temp var, since it's abundantly clear that we're manipulating the data-to-be-restored before the restore happens.

Comment 6

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Attachment: Patch v1.0

Addressed comments

Comment 7

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/f19cab5d3f77

Comment 8

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

http://hg.mozilla.org/mozilla-central/rev/f19cab5d3f77