645750 - nsCSSParser.cpp:8060:19: warning: unused variable ‘variantMask’ (also ‘table’)

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Daniel Holbert [:dholbert]]

Attachment: fix

> nsCSSParser.cpp:8060:19: warning: unused variable ‘variantMask’
> nsCSSParser.cpp:8061:26: warning: unused variable ‘table’

These variables last usages were removed in
  http://hg.mozilla.org/mozilla-central/rev/f0f1632c19e8

Fix attached (just removing the variables)

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 522394 [details] [diff] [review]
fix

r=dbaron, though this isn't the first time I've reviewed a fix for this warning

Comment 2

[Daniel Holbert [:dholbert]]

(In reply to comment #1) 
> r=dbaron
thanks!

> though this isn't the first time I've reviewed a fix for this warning

Hmm, thanks for the heads-up...  I searched Bugzilla for 'variantMask' in both bug-summary & bug-comments, and I didn't find anything recent...  If I come across a dupe, I'll mark as appropriate, but otherwise I'll likely just land this today or tomorrow, with a bundle of other patches that I'm TryServer-testing right now.

Comment 3

[Daniel Holbert [:dholbert]]

(In reply to comment #2)
> I'll likely just land
> this today or tomorrow, with a bundle of other patches that I'm
> TryServer-testing right now.

D'oh, I forgot to include this in my landing.  I'll post a |hg export| version that hopefully someone can take as a ridealong.

Comment 4

[Daniel Holbert [:dholbert]]

Attachment: hg changeset for landing

Comment 5

[Alon Zakai (:azakai)]

http://hg.mozilla.org/mozilla-central/rev/8beb43b5e113