Remove NS_NewCSS*Rule functions

RESOLVED FIXED in mozilla5

Status

()

Core
CSS Parsing and Computation
--
minor
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: Craig Topper, Assigned: Craig Topper)

Tracking

Trunk
mozilla5
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(5 attachments)

(Assignee)

Description

7 years ago
Now that all the CSS rule interface classes are gone we no longer need these creation functions and we can just allocate the classes directly.
(Assignee)

Comment 1

7 years ago
Created attachment 522596 [details] [diff] [review]
Part 1: Remove NS_NewCSSStyleRule
(Assignee)

Comment 2

7 years ago
Created attachment 522597 [details] [diff] [review]
Part 2: Remove NS_NewCSSImportRule
(Assignee)

Comment 3

7 years ago
Created attachment 522599 [details] [diff] [review]
Part 3: Remove NS_NewCSSNamespaceRule
(Assignee)

Comment 4

7 years ago
Created attachment 522600 [details] [diff] [review]
Part 4: Move CSSCharsetRule to header file and put in css namespace
(Assignee)

Comment 5

7 years ago
Created attachment 522601 [details] [diff] [review]
Part 5: Remove NS_NewCSSCharsetRule
(Assignee)

Updated

7 years ago
Attachment #522596 - Flags: review?(bzbarsky)
(Assignee)

Updated

7 years ago
Attachment #522597 - Flags: review?(bzbarsky)
(Assignee)

Updated

7 years ago
Attachment #522599 - Flags: review?(bzbarsky)
(Assignee)

Updated

7 years ago
Attachment #522600 - Flags: review?(bzbarsky)
(Assignee)

Updated

7 years ago
Attachment #522601 - Flags: review?(bzbarsky)
Comment on attachment 522596 [details] [diff] [review]
Part 1: Remove NS_NewCSSStyleRule

r=me
Attachment #522596 - Flags: review?(bzbarsky) → review+
Comment on attachment 522597 [details] [diff] [review]
Part 2: Remove NS_NewCSSImportRule

r=me
Attachment #522597 - Flags: review?(bzbarsky) → review+
Comment on attachment 522599 [details] [diff] [review]
Part 3: Remove NS_NewCSSNamespaceRule

r=me
Attachment #522599 - Flags: review?(bzbarsky) → review+
Depends on: 577976
Comment on attachment 522600 [details] [diff] [review]
Part 4: Move CSSCharsetRule to header file and put in css namespace

r=me
Attachment #522600 - Flags: review?(bzbarsky) → review+
Comment on attachment 522601 [details] [diff] [review]
Part 5: Remove NS_NewCSSCharsetRule

r=me
Attachment #522601 - Flags: review?(bzbarsky) → review+
Pushed:
  http://hg.mozilla.org/mozilla-central/rev/3a7b91a4166f
  http://hg.mozilla.org/mozilla-central/rev/5a9e6e008e19
  http://hg.mozilla.org/mozilla-central/rev/cefe71fc5e19
  http://hg.mozilla.org/mozilla-central/rev/7d61a9406c03
  http://hg.mozilla.org/mozilla-central/rev/ec38f9d0e7c2
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.2
You need to log in before you can comment on or make changes to this bug.