645963 - in the bookmarks toolbar TEXT only view, there are no double arrows showing at the end of the bar to allow access to bookmarks that are more than can be fitted on screen

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[gobang91894]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2.11) Gecko/20101012 Firefox/3.6.11
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2.11) Gecko/20101012 Firefox/3.6.11

in the bookmarks toolbar TEXT only view, there are no double arrows showing at the end of the bar to allow access to bookmarks that are more than can be fitted on screen. The arrows are there in the icons and text view, but not in the text only view

Reproducible: Always

Steps to Reproduce:
1.its a view problem
2.
3.

Comment 1

[gobang91894]

Attachment: Screen view

view

Comment 2

[gobang91894]

Attachment: What shows in icon & text view

Comment 3

[Marco Bonardo [:mak]]

Hi, how did you enable the text-only view?

Comment 4

[gobang91894]

(In reply to comment #3)
> Hi, how did you enable the text-only view?

If you have Firefox 4 installed on a mac: open firefox, go to view in menu bar, from drop down menu go to tool bar/then customize. In the window that opens the is a spot at the bottom that  says SHOW and next to it you can chose 1]Icons 2)icons & Text 3)text only..........make your choice. Its also in firefox 3

Comment 5

[Marco Bonardo [:mak]]

yeah, I can reproduce, the chevron button should not be affected but it is.

Comment 6

[Stefan [:stefanh]]

Attachment: Make the chevron visible in text mode

What's happening here is that xul.css sets display:none for all toolbarbutton-icon's when the toolbar is in text mode. Pinstripe lacks an override (which is present in gnome/winstripe.

Comment 7

[Stefan [:stefanh]]

Comment on attachment 543684 [details] [diff] [review]
Make the chevron visible in text mode

Whoops, wrong patch

Comment 8

[Stefan [:stefanh]]

Attachment: Correct patch

Sorry, uploaded the wrong patch - see comment #6 for the background.

Comment 9

[Stefan [:stefanh]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/a7bf24902032

Comment 10

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/a7bf24902032

Comment 11

[Simona Badau, Desktop QA]

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:7.0a2) Gecko/20110706 Firefox/7.0a2

Verified on MacOS X 10.6  that double arrows are present at the end of the  Bookmarks Toolbar when bookmarks are in text view.