646118 - ImportError on reconfig on pm01

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P3)

Description

[Dustin J. Mitchell [:dustin] (he/him)]

[production-master01.build.mozilla.org] out:    Traceback (most recent call last):
[production-master01.build.mozilla.org] out:      File "/tools/buildbot-0.8.2/lib/python2.6/site-packages/Twisted-10.1.0-py2.6-linux-i686.egg/twisted/application/app.py", line 311, in runReactorWithLogging
[production-master01.build.mozilla.org] out:        reactor.run()
[production-master01.build.mozilla.org] out:      File "/tools/buildbot-0.8.2/lib/python2.6/site-packages/Twisted-10.1.0-py2.6-linux-i686.egg/twisted/internet/base.py", line 1165, in run
[production-master01.build.mozilla.org] out:        self.mainLoop()
[production-master01.build.mozilla.org] out:      File "/tools/buildbot-0.8.2/lib/python2.6/site-packages/Twisted-10.1.0-py2.6-linux-i686.egg/twisted/internet/base.py", line 1174, in mainLoop
[production-master01.build.mozilla.org] out:        self.runUntilCurrent()
[production-master01.build.mozilla.org] out:      File "/tools/buildbot-0.8.2/lib/python2.6/site-packages/Twisted-10.1.0-py2.6-linux-i686.egg/twisted/internet/base.py", line 796, in runUntilCurrent
[production-master01.build.mozilla.org] out:        call.func(*call.args, **call.kw)
[production-master01.build.mozilla.org] out:    --- <exception caught here> ---
[production-master01.build.mozilla.org] out:      File "/tools/buildbot-0.8.2/lib/python2.6/site-packages/buildbot-0.8.2_hg_a63f22816750_production_0.8-py2.6.egg/buildbot/master.py", line 600, in loadTheConfigFile
[production-master01.build.mozilla.org] out:        d = self.loadConfig(f)
[production-master01.build.mozilla.org] out:      File "/tools/buildbot-0.8.2/lib/python2.6/site-packages/buildbot-0.8.2_hg_a63f22816750_production_0.8-py2.6.egg/buildbot/master.py", line 624, in loadConfig
[production-master01.build.mozilla.org] out:        exec f in localDict
[production-master01.build.mozilla.org] out:      File "/builds/buildbot/builder_master1/master.cfg", line 12, in <module>
[production-master01.build.mozilla.org] out:        reload(master_localconfig)
[production-master01.build.mozilla.org] out:      File "/builds/buildbot/builder_master1/master_localconfig.py", line 14, in <module>
[production-master01.build.mozilla.org] out:        from config import BRANCHES, SLAVES, PROJECTS, ACTIVE_PROJECT_BRANCHES
[production-master01.build.mozilla.org] out:    exceptions.ImportError: cannot import name ACTIVE_PROJECT_BRANCHES

This passed a checkconfig but not a reconfig.

I added

import config
reload(config)

locally to get past it, but I doubt that's the right solution.

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: m646118-bbcfg-r1.patch

I know it's not a "good" solution, but since it's in place on the masters, it should probably be in hg.

Comment 2

[[e-mail] (:bhearsum)]

Comment on attachment 523305 [details] [diff] [review]
m646118-bbcfg-r1.patch

Yup, local changes--

Comment 3

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 523305 [details] [diff] [review]
m646118-bbcfg-r1.patch

I'm leaving this open because it may not be the best fix.

Comment 4

[Chris Cooper [:coop] (he/him)]

Removing the [buildduty] tag since I think this is outside the scope of what buildduty should be responsible for.

Does someone need to look at our import/reload story again to see where this is being dropped on the floor, or are we going to land the attached patch?

Comment 5

[Dustin J. Mitchell [:dustin] (he/him)]

It's landed - I just don't know if this is the best fix, so let's keep it open.

Comment 6

[Dustin J. Mitchell [:dustin] (he/him)]

Presumably my fix is good enough, so I guess we can close this?