646136 - Firefox 3.5.18/3.6.16 sr unexpectedly offered advertised update to Firefox 4.0

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[u279076]

According to Axel, the SR locale should NOT be offered an advertised update to Firefox 4 on releasetest.  However, these builds are being offered the update.

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

I'm not sure why this is happening, as I should have been using the copy of the snippets with already had sr pulled. Will investigate.

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

The snippets were generated in bug 645551. Checking those directories:
$ find Firefox-{3.6.16,3.5.18}-build1-4.0-MU-https{,-beta,-test} -type d -name 'sr'
Firefox-3.6.16-build1-4.0-MU-https-test/Firefox/3.6.16/Darwin_x86-gcc3-u-ppc-i386/20110319135224/sr
Firefox-3.6.16-build1-4.0-MU-https-test/Firefox/3.6.16/Linux_x86-gcc3/20110319135224/sr
Firefox-3.6.16-build1-4.0-MU-https-test/Firefox/3.6.16/WINNT_x86-msvc/20110319135224/sr
Firefox-3.5.18-build1-4.0-MU-https-test/Firefox/3.5.18/Darwin_x86-gcc3-u-ppc-i386/20110319140258/sr
Firefox-3.5.18-build1-4.0-MU-https-test/Firefox/3.5.18/Linux_x86-gcc3/20110319140258/sr
Firefox-3.5.18-build1-4.0-MU-https-test/Firefox/3.5.18/WINNT_x86-msvc/20110319140258/sr

So this is only an issue on the tests channels. The beta and release channels have no sr/ subdirectories. 

The problem arose because sr was not pulled from the -test directories I copied from, https://wiki.mozilla.org/Releases/Firefox_4.0/BuildNotes#Remove_Serbian_snippets_from_MU

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

Fixes:

1, fix live snippets (separately in MPT and PHX)
cd /opt/aus2/incoming/3
find Firefox/{3.5.18,3.6.16} -depth -type d -name sr -exec rm -rfv {} \;

Only deletes releasetest, and even older betatest, snippets.

Comment 4

[Nick Thomas [:nthomas] (UTC+12)]

We need to do the same trick as https://wiki.mozilla.org/Releases/Firefox_4.0/BuildNotes#Remove_updates_for_broken_locales for a few mac locales. Slightly different here, the () make the or match catch all the locales properly.

1b, fix live snippets (separately in MPT and PHX)
cd /opt/aus2/incoming/3
find Firefox/3.6.16/Darwin_* -depth -type d \( -name ml -o -name te \) -exec rm -rfv {} \;
find Firefox/3.5.18/Darwin_* -depth -type d \( -name kn -o -name ml -o -name te \) -exec rm -rfv {} \;

Comment 5

[Nick Thomas [:nthomas] (UTC+12)]

2, generate a set of test snippest without sr, in case we need to do more hacking up of snippets in the future. (at MPT). Sorry, no backup.

cd /opt/aus2/snippets/staging
for d in Firefox-3.6.16-build1-4.0-MU-https-test \
         Firefox-3.5.18-build1-4.0-MU-https-test; do 
  find $d -depth -type d -name sr -exec rm -rfv {} \;
done
find Firefox-3.6.16-build1-4.0-MU-https-test/Firefox/3.6.16/Darwin_* -depth -type d \( -name ml -o -name te \) -exec rm -rfv {} \;
find Firefox-3.5.18-build1-4.0-MU-https-test/Firefox/3.5.18/Darwin_* -depth -type d \( -name kn -o -name ml -o -name te \) -exec rm -rfv {} \;

Comment 6

[Nick Thomas [:nthomas] (UTC+12)]

3, do consistency checks for 3.6.16
# releasetest == beta
find Firefox-3.6.16-build1-4.0-MU-https-test -type d -iregex '.*/releasetest$' | perl -nle '$a = $_; $a =~ s/releasetest/beta/; $a =~ s/-test/-beta/; system("diff -r -u $_ $a");'
diff: Firefox-3.6.16-build1-4.0-MU-https-beta/Firefox/3.6.16/Darwin_x86-gcc3-u-ppc-i386/20110319135224/kn/beta: No such file or directory

find Firefox-3.6.16-build1-4.0-MU-https-beta -type d -iregex '.*/beta$' | perl -nle '$a = $_; $a =~ s/beta$/releasetest/; $a =~ s/-beta/-test/; system("diff -r -u $_ $a");'

# beta == release
find Firefox-3.6.16-build1-4.0-MU-https -type d -iregex '.*/release$' | perl -nle '$a = $_; $a =~ s/release/beta/; $a =~ s/MU-https/MU-https-beta/; system("diff -r -u $_ $a");'
find Firefox-3.6.16-build1-4.0-MU-https-beta -type d -iregex '.*/beta$' | perl -nle '$a = $_; $a =~ s/beta$/release/; $a =~ s/-beta//; system("diff -r -u $_ $a");'

So there is a releasetest update for kn but no matching snippets for beta or release. Copy it over:

mkdir Firefox-3.6.16-build1-4.0-MU-https{-beta,}/Firefox/3.6.16/Darwin_x86-gcc3-u-ppc-i386/20110319135224/kn
rsync -av Firefox-3.6.16-build1-4.0-MU-https-test/Firefox/3.6.16/Darwin_x86-gcc3-u-ppc-i386/20110319135224/kn/releasetest/ Firefox-3.6.16-build1-4.0-MU-https-beta/Firefox/3.6.16/Darwin_x86-gcc3-u-ppc-i386/20110319135224/kn/beta/
rsync -av Firefox-3.6.16-build1-4.0-MU-https-test/Firefox/3.6.16/Darwin_x86-gcc3-u-ppc-i386/20110319135224/kn/releasetest/ Firefox-3.6.16-build1-4.0-MU-https/Firefox/3.6.16/Darwin_x86-gcc3-u-ppc-i386/20110319135224/kn/release/

Consistency checks are now all clean.

4, OMG WORKING WITH THIS STUFF SUCKS

Comment 7

[Nick Thomas [:nthomas] (UTC+12)]

4, do consistency checks for 3.5.18
# releasetest == beta
find Firefox-3.5.18-build1-4.0-MU-https-test -type d -iregex '.*/releasetest$' | perl -nle '$a = $_; $a =~ s/releasetest/beta/; $a =~ s/-test/-beta/; system("diff -r -u $_ $a");'
find Firefox-3.5.18-build1-4.0-MU-https-beta -type d -iregex '.*/beta$' | perl -nle '$a = $_; $a =~ s/beta$/releasetest/; $a =~ s/-beta/-test/; system("diff -r -u $_ $a");'

# beta == release
find Firefox-3.5.18-build1-4.0-MU-https -type d -iregex '.*/release$' | perl -nle '$a = $_; $a =~ s/release/beta/; $a =~ s/MU-https/MU-https-beta/; system("diff -r -u $_ $a");'
find Firefox-3.5.18-build1-4.0-MU-https-beta -type d -iregex '.*/beta$' | perl -nle '$a = $_; $a =~ s/beta$/release/; $a =~ s/-beta//; system("diff -r -u $_ $a");'

All clean.

Comment 8

[u279076]

So testers checking SR on releasetest should no longer get an update?

Comment 9

[Nick Thomas [:nthomas] (UTC+12)]

The net result of all that verboseness above is 
* no updates for sr on releasetest (there was never any on beta/release)
* no updates for kn,ml,te on 3.5.18, or ml,te on 3.6.16 on Mac