Last Comment Bug 646180 - init list order warning in nsPresContext (nsPresContext::mPPScale’ will be initialized after ‘PRInt32 nsPresContext::mMinFontSize’)
: init list order warning in nsPresContext (nsPresContext::mPPScale’ will be in...
Status: RESOLVED FIXED
[build_warning]
:
Product: Core
Classification: Components
Component: Layout (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla6
Assigned To: Daniel Holbert [:dholbert]
:
Mentors:
Depends on:
Blocks: 623820
  Show dependency treegraph
 
Reported: 2011-03-29 12:47 PDT by Daniel Holbert [:dholbert]
Modified: 2011-05-24 03:43 PDT (History)
0 users
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
fix: reorder init list (1.47 KB, patch)
2011-05-23 10:05 PDT, Daniel Holbert [:dholbert]
roc: review+
Details | Diff | Splinter Review

Description Daniel Holbert [:dholbert] 2011-03-29 12:47:59 PDT
../../../mozilla/layout/base/nsPresContext.h: In constructor ‘nsPresContext::nsPresContext(nsIDocument*, nsPresContext::nsPresContextType)’:
../../../mozilla/layout/base/nsPresContext.h:1105:9: warning: ‘nsPresContext::mPPScale’ will be initialized after
../../../mozilla/layout/base/nsPresContext.h:1074:11: warning:   ‘PRInt32 nsPresContext::mMinFontSize’
../../../mozilla/layout/base/nsPresContext.cpp:187:1: warning:   when initialized here
Comment 1 Daniel Holbert [:dholbert] 2011-05-23 10:05:41 PDT
Created attachment 534465 [details] [diff] [review]
fix: reorder init list

I've seen this fly by in too many of my builds, so I decided to fix it. :)

Patch just bumps the "mMinFontSize" back before "mTextZoom", to match the ordering in the .h file.
Comment 2 Robert O'Callahan (:roc) (email my personal email if necessary) 2011-05-23 15:37:37 PDT
Comment on attachment 534465 [details] [diff] [review]
fix: reorder init list

Review of attachment 534465 [details] [diff] [review]:
-----------------------------------------------------------------
Comment 3 Daniel Holbert [:dholbert] 2011-05-24 03:43:09 PDT
http://hg.mozilla.org/mozilla-central/rev/db38a9fdd271

Note You need to log in before you can comment on or make changes to this bug.