Closed Bug 646180 Opened 13 years ago Closed 13 years ago

init list order warning in nsPresContext (nsPresContext::mPPScale’ will be initialized after ‘PRInt32 nsPresContext::mMinFontSize’)

Categories

(Core :: Layout, defect)

Product:
Core
Component:
Layout
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla6

People

(Reporter: dholbert, Assigned: dholbert)

References

Details

(Whiteboard: [build_warning])

Attachments

(1 file)

fix: reorder init list
1.47 KB, patch
roc
: review+
Details | Diff | Splinter Review 
../../../mozilla/layout/base/nsPresContext.h: In constructor ‘nsPresContext::nsPresContext(nsIDocument*, nsPresContext::nsPresContextType)’:
../../../mozilla/layout/base/nsPresContext.h:1105:9: warning: ‘nsPresContext::mPPScale’ will be initialized after
../../../mozilla/layout/base/nsPresContext.h:1074:11: warning:   ‘PRInt32 nsPresContext::mMinFontSize’
../../../mozilla/layout/base/nsPresContext.cpp:187:1: warning:   when initialized here
I've seen this fly by in too many of my builds, so I decided to fix it. :)

Patch just bumps the "mMinFontSize" back before "mTextZoom", to match the ordering in the .h file.
Assignee: nobody → dholbert
Attachment #534465 - Flags: review?(roc)
Comment on attachment 534465 [details] [diff] [review]
fix: reorder init list

Review of attachment 534465 [details] [diff] [review]:
-----------------------------------------------------------------
Attachment #534465 - Flags: review?(roc) → review+
http://hg.mozilla.org/mozilla-central/rev/db38a9fdd271
Status: NEW → RESOLVED
Closed: 13 years ago
OS: Linux → All
Hardware: x86_64 → All
Resolution: --- → FIXED
Target Milestone: --- → mozilla6
You need to log in before you can comment on or make changes to this bug.