Closed
Bug 646253
Opened 10 years ago
Closed 10 years ago
The end caps on the About:Home page is incorrect
Categories
(Firefox for Android Graveyard :: General, defect)
Firefox for Android Graveyard
General
Tracking
(Not tracked)
VERIFIED
FIXED
Firefox 5
People
(Reporter: nhirata, Assigned: linostar)
References
()
Details
(Keywords: rtl)
Attachments
(3 files, 2 obsolete files)
1. install the arabic plugin from : http://ftp.mozilla.org/pub/mozilla.org/mobile/nightly/latest-mozilla-central-linux-l10n/ 2. switch to arabic and restart 3. go to about:home 4. pan all the way down and Look at the last 2 buttons Expected: it looks like a capsule Actual: the end caps are in the middle and the square parts are at the end
Assignee | ||
Updated•10 years ago
|
Component: ar / Arabic → Themes
Product: Mozilla Localizations → Toolkit
QA Contact: arabic.ar → themes
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → linux.anas
Status: NEW → ASSIGNED
Assignee | ||
Updated•10 years ago
|
OS: Mac OS X → All
Hardware: x86 → All
Assignee | ||
Comment 1•10 years ago
|
||
Assignee | ||
Comment 2•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Attachment #522961 -
Flags: feedback?(ehsan)
Assignee | ||
Comment 3•10 years ago
|
||
Both 'he' and 'fa' are also affected by this bug.
Updated•10 years ago
|
Component: Themes → General
Product: Toolkit → Fennec
QA Contact: themes → general
Version: unspecified → Trunk
Comment 4•10 years ago
|
||
Comment on attachment 522961 [details] [diff] [review] Patch for correcting the button borders on about:home Hey Anas, Sounds good but can you try to replace the border-left/right by -moz-border-start instead? ( see https://developer.mozilla.org/en/Making_Sure_Your_Theme_Works_with_RTL_Locales#Using_start.2fend_rules_instead_of_left.2fright_rules )
Attachment #522961 -
Flags: feedback?(ehsan) → feedback+
Assignee | ||
Comment 5•10 years ago
|
||
Attachment #522961 -
Attachment is obsolete: true
Attachment #523010 -
Flags: feedback?(21)
Comment 6•10 years ago
|
||
(In reply to comment #5) > Created attachment 523010 [details] [diff] [review] > patch v2 Using moz-border-start you can probably do: #support { -moz-border-start: none; } instead of adding the rule each time in the rules with [rtl] selector
Assignee | ||
Comment 7•10 years ago
|
||
could do it in that patch, but was in a hurry :)
Attachment #523010 -
Attachment is obsolete: true
Attachment #523010 -
Flags: feedback?(21)
Assignee | ||
Updated•10 years ago
|
Attachment #523030 -
Flags: feedback?(21)
Comment 8•10 years ago
|
||
Comment on attachment 523030 [details] [diff] [review] patch v2.1 I will land it soon. Thanks for the patch :)
Attachment #523030 -
Flags: feedback?(21) → review+
Comment 9•10 years ago
|
||
http://hg.mozilla.org/mobile-browser/rev/d853ebaf4533
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment 10•10 years ago
|
||
Verified on build: Mozilla /5.0 (Android;Linux armv7l;rv:2.2a1pre) Gecko/20110331 Firefox/4.2a1pre Fennec /4.1a1pre Device: HTC Desire (Android 2.2)
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•