646253 - The end caps on the About:Home page is incorrect

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Attachment: screenshot

1. install the arabic plugin from : http://ftp.mozilla.org/pub/mozilla.org/mobile/nightly/latest-mozilla-central-linux-l10n/
2. switch to arabic and restart
3. go to about:home
4. pan all the way down and Look at the last 2 buttons

Expected: it looks like a capsule
Actual: the end caps are in the middle and the square parts are at the end

Comment 1

[Anas Husseini [:linostar]]

Attachment: Patch for correcting the button borders on about:home

Comment 2

[Anas Husseini [:linostar]]

Attachment: screenshot of about:home after applying the patch

Comment 3

[Anas Husseini [:linostar]]

Both 'he' and 'fa' are also affected by this bug.

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 522961 [details] [diff] [review]
Patch for correcting the button borders on about:home

Hey Anas,
Sounds good but can you try to replace the border-left/right by -moz-border-start instead? ( see https://developer.mozilla.org/en/Making_Sure_Your_Theme_Works_with_RTL_Locales#Using_start.2fend_rules_instead_of_left.2fright_rules )

Comment 5

[Anas Husseini [:linostar]]

Attachment: patch v2

Comment 6

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to comment #5)
> Created attachment 523010 [details] [diff] [review]
> patch v2

Using moz-border-start you can probably do:

#support {
 -moz-border-start: none;
}

instead of adding the rule each time in the rules with [rtl] selector

Comment 7

[Anas Husseini [:linostar]]

Attachment: patch v2.1

could do it in that patch, but was in a hurry :)

Comment 8

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 523030 [details] [diff] [review]
patch v2.1

I will land it soon. Thanks for the patch :)

Comment 9

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

http://hg.mozilla.org/mobile-browser/rev/d853ebaf4533

Comment 10

[Andreea Pod]

Verified on build: Mozilla /5.0 (Android;Linux armv7l;rv:2.2a1pre) Gecko/20110331 Firefox/4.2a1pre Fennec /4.1a1pre 
Device: HTC Desire (Android 2.2)