Closed Bug 646263 Opened 10 years ago Closed 10 years ago

TI: Incorrect results with compiled CPython

Categories

(Core :: JavaScript Engine, defect)

Other Branch
x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: azakai, Unassigned)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

The attachment is CPython compiled to JavaScript (two versions - one with optimizations, one without). Running it in jaegermonkey with -m gives incorrect errors, while running without -m works fine.

This is similar and perhaps related to bug 643805.

Btw, after the previous TI/compiled code bugs were fixed, currently all 528 of the emscripten automatic tests pass except for FreeType (bug 643805) and this one. Very nice!
Attached file unoptimized python
Attached file optimized python
(In reply to comment #0)
> Btw, after the previous TI/compiled code bugs were fixed, currently all 528 of
> the emscripten automatic tests pass except for FreeType (bug 643805) and this
> one. Very nice!

Nice! Is this also with -n? (-n enables TI, so |-m -n| or |-m -n -a| are the most interesting options).

I will reduce this one after bug 643805 is fixed. 500,000 lines will take some time ;)
(In reply to comment #3)
> Is this also with -n? (-n enables TI, so |-m -n| or |-m -n -a| are the
> most interesting options).
> 

It looks like there are some additional errors there. I'll file some bugs when the tests finish running.
This might have been fixed by other commits from bhackett, I cannot reproduce. Alon, can you still reproduce this, and if so what options are you using?
I can still reproduce a problem on latest jaegermonkey, with |-m -a -n|.
Both attachments work now with |-n -m|, |-n -m -a|, |-m -a| etc. Probably fixed by http://hg.mozilla.org/projects/jaegermonkey/rev/d78eef12a329

Alon, can you verify that we pass all emscripten tests now?
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
(In reply to comment #7)
> Both attachments work now with |-n -m|, |-n -m -a|, |-m -a| etc. Probably fixed
> by http://hg.mozilla.org/projects/jaegermonkey/rev/d78eef12a329
> 
> Alon, can you verify that we pass all emscripten tests now?

I tried, but I can't build JM due to bug 644938.
(In reply to comment #7)
> Alon, can you verify that we pass all emscripten tests now?

All emscripten tests now pass! :)
I spoke too soon. They pass with |-m -a -n|, but I am seeing crashes with |-m -j -p -n|. Will file bugs.
You need to log in before you can comment on or make changes to this bug.