TI: Incorrect results with compiled CPython

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: azakai, Unassigned)

Tracking

(Blocks: 1 bug)

Other Branch
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

1.38 MB, application/octet-stream
Details
1.80 MB, application/octet-stream
Details
(Reporter)

Description

6 years ago
The attachment is CPython compiled to JavaScript (two versions - one with optimizations, one without). Running it in jaegermonkey with -m gives incorrect errors, while running without -m works fine.

This is similar and perhaps related to bug 643805.

Btw, after the previous TI/compiled code bugs were fixed, currently all 528 of the emscripten automatic tests pass except for FreeType (bug 643805) and this one. Very nice!
(Reporter)

Comment 1

6 years ago
Created attachment 522850 [details]
unoptimized python
(Reporter)

Comment 2

6 years ago
Created attachment 522851 [details]
optimized python
(In reply to comment #0)
> Btw, after the previous TI/compiled code bugs were fixed, currently all 528 of
> the emscripten automatic tests pass except for FreeType (bug 643805) and this
> one. Very nice!

Nice! Is this also with -n? (-n enables TI, so |-m -n| or |-m -n -a| are the most interesting options).

I will reduce this one after bug 643805 is fixed. 500,000 lines will take some time ;)
(Reporter)

Comment 4

6 years ago
(In reply to comment #3)
> Is this also with -n? (-n enables TI, so |-m -n| or |-m -n -a| are the
> most interesting options).
> 

It looks like there are some additional errors there. I'll file some bugs when the tests finish running.
This might have been fixed by other commits from bhackett, I cannot reproduce. Alon, can you still reproduce this, and if so what options are you using?
(Reporter)

Comment 6

6 years ago
I can still reproduce a problem on latest jaegermonkey, with |-m -a -n|.
Both attachments work now with |-n -m|, |-n -m -a|, |-m -a| etc. Probably fixed by http://hg.mozilla.org/projects/jaegermonkey/rev/d78eef12a329

Alon, can you verify that we pass all emscripten tests now?
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
(Reporter)

Comment 8

6 years ago
(In reply to comment #7)
> Both attachments work now with |-n -m|, |-n -m -a|, |-m -a| etc. Probably fixed
> by http://hg.mozilla.org/projects/jaegermonkey/rev/d78eef12a329
> 
> Alon, can you verify that we pass all emscripten tests now?

I tried, but I can't build JM due to bug 644938.
(Reporter)

Comment 9

6 years ago
(In reply to comment #7)
> Alon, can you verify that we pass all emscripten tests now?

All emscripten tests now pass! :)
(Reporter)

Comment 10

6 years ago
I spoke too soon. They pass with |-m -a -n|, but I am seeing crashes with |-m -j -p -n|. Will file bugs.
You need to log in before you can comment on or make changes to this bug.