Closed Bug 646270 Opened 9 years ago Closed 9 years ago

MozScrolledAreaChanged changed behavior and broke some browser-chrome tests

Categories

(Firefox for Android Graveyard :: General, defect)

x86
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mfinkle, Assigned: mfinkle)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
"MozScrolledAreaChanged" is now always fired before "pageshow" for initial page sizing. That breaks some test code that used the message as a post-pageshow helper. I ditched that code and reverted back to simpler code to get tests green on linux desktop.

I also turned off a scrollbar tests. It seems we will grow the height of a document based on the width to ensure zooming out to the width will always have document available height-wise. This breaks a scrollbar test that assumes the vertical scrollbar will not be visible.

Linux desktop tests are green with patch.

We could change our behavior to not over extend the height unless we actually need to, dynamically based on current zoom. Filing a bug for that.
Attachment #522864 - Flags: review?(mbrubeck)
Attachment #522864 - Flags: review?(mbrubeck) → review+
pushed:
http://hg.mozilla.org/mobile-browser/rev/3f9373ef450e
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
bugspam
Assignee: nobody → mark.finkle
You need to log in before you can comment on or make changes to this bug.