646276 - Images are all blocky

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

This shows blocky images with current trunk. It looks fine with FF 4. http://ie.microsoft.com/testdrive/Graphics/Transform2D/Default.html

This was not caused by the pixman update.

Comment 1

[Boris Zbarsky [:bzbarsky]]

How do we nominate bugs to block fx5 (in the "need to find what caused this and get rid of it" sense)?

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

It looks like the resolution clamping and automatic rerendering is broken...

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

The problem here is that we're creating an intermediate surface for a ContainerLayer and ContainerLayers don't know about resolutions. So the ThebesLayer's effective transform is just a translation, but then we scale the ContainerLayer's intermediate surface up a lot when we draw that.

I don't know how this worked in Firefox 4, I'm not aware of any relevant code that's changed.

Comment 4

[Alice0775 White]

Probably I may misread STR and the issue(I don't understand "all blocky").

However, I notice one problem.
The image is blurred while image zoom-in. And then the image is repainted with correct resolution.

Regression window ;
Works:
http://hg.mozilla.org/mozilla-central/rev/488ea306526b
Mozilla/5.0 (Windows; Windows NT 6.1; WOW64; rv:2.0b3pre) Gecko/20100801
Minefield/4.0b3pre ID:20100801201130
Fails:
http://hg.mozilla.org/mozilla-central/rev/99807f92a67c
Mozilla/5.0 (Windows; Windows NT 6.1; WOW64; rv:2.0b3pre) Gecko/20100801
Minefield/4.0b3pre ID:20100801221929
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=488ea306526b&tochange=99807f92a67c
In local build on ubuntu10.04(from m-c repository):
build from 9a45bd27ec75 : fails
build from ed9773300a85 : works
Triggered by : 9a45bd27ec75	Matt Woodrow — Bug 505115. Use layers to render active 2D transforms. r=roc,dbaron
And Bug 604899 may be related, 

I'm sorry if I misunderstand it.

Comment 5

[Jeff Muizelaar [:jrmuizel]]

Turns out when I saw this, I was running basic layers in FF4. So there isn't a real regression here. However, basic layers does look much better than accelerated layers.

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Thanks Alice, you're absolutely right as usual!

I think BasicLayers is looking better because we choose to use component alpha for the transformed stuff (not sure why actually) and BasicLayers doesn't retain component alpha, so everything just gets rerendered from scratch all the time.

I think the right way to fix this is to move the resolution functionality out of the layer system altogether, as we've discussed in the past to fix other bugs. I'll do that in bug 646607.

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Should have been fixed in bug 637852. Please retest on a nightly build.

Comment 8

[Alice0775 White]

I cannot reproduce on Firefox/10.0.2, 11Beta, Aurora12.0a2 and Nightly13.0a1 anymore.

Comment 9

[Timothy Nikkel (:tnikkel)]

Thanks Alice. Let's call it fixed then. Please reopen if that is not the case.