646304 - Warning C4099: 'JSString' : type name first seen using 'struct' now seen using 'class'

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

On current m-c, this warning is spammed all over the tree.

c:\mozbuild\mozilla-central\objdir-fx\dist\include\jsval.h(271) : warning C4099: 'JSString' : type name first seen using 'struct' now seen using 'class'
        c:\mozbuild\mozilla-central\objdir-fx\dist\include\nsXULAppAPI.h(548) : see declaration of 'JSString'

Comment 1

[Ryan VanderMeulen [:RyanVM]]

http://mxr.mozilla.org/mozilla-central/source/js/src/jsval.h#270

So jsval.h defines JSString as a class ifdef __cplusplus and otherwise as a struct. nxXULAppAPI.h declares it as a struct with no ifdefs. The change was made in bug 613457.

Luke, this is a very painful warning as it spams all over the tree.

Comment 2

[Luke Wagner [:luke]]

I hate that warning.  Can we turn it off globally?

Comment 3

[David Mandelin [:dmandelin]]

Attachment: Patch

Comment 4

[David Mandelin [:dmandelin]]

http://hg.mozilla.org/tracemonkey/rev/df211d75bddc

Comment 5

[Chris Leary [:cdleary] (not checking bugmail)]

cdleary-bot mozilla-central merge info:
http://hg.mozilla.org/mozilla-central/rev/df211d75bddc

Comment 6

[Chris Leary [:cdleary] (not checking bugmail)]

cdleary-bot mozilla-central merge info:
http://hg.mozilla.org/mozilla-central/rev/df211d75bddc

Comment 7

[Chris Leary [:cdleary] (not checking bugmail)]

Sorry for the extra comment, working out a few kinks.