Closed Bug 646304 Opened 9 years ago Closed 9 years ago

Warning C4099: 'JSString' : type name first seen using 'struct' now seen using 'class'

Categories

(Core :: JavaScript Engine, defect)

x86
Windows 7
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: RyanVM, Assigned: dmandelin)

References

Details

(Whiteboard: [build_warning][fixed-in-tracemonkey])

Attachments

(1 file)

On current m-c, this warning is spammed all over the tree.

c:\mozbuild\mozilla-central\objdir-fx\dist\include\jsval.h(271) : warning C4099: 'JSString' : type name first seen using 'struct' now seen using 'class'
        c:\mozbuild\mozilla-central\objdir-fx\dist\include\nsXULAppAPI.h(548) : see declaration of 'JSString'
Whiteboard: [build_warning]
http://mxr.mozilla.org/mozilla-central/source/js/src/jsval.h#270

So jsval.h defines JSString as a class ifdef __cplusplus and otherwise as a struct. nxXULAppAPI.h declares it as a struct with no ifdefs. The change was made in bug 613457.

Luke, this is a very painful warning as it spams all over the tree.
Blocks: 613457
I hate that warning.  Can we turn it off globally?
Attached patch PatchSplinter Review
Assignee: general → dmandelin
Status: NEW → ASSIGNED
Attachment #522907 - Flags: review?(bent.mozilla)
Attachment #522907 - Flags: review?(bent.mozilla) → review+
http://hg.mozilla.org/tracemonkey/rev/df211d75bddc
Whiteboard: [build_warning] → [build_warning][fixed-in-tracemonkey]
Sorry for the extra comment, working out a few kinks.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.