646444 - Add search engine not present in page's favicon.

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Ioana Chiorean]

Build id : Mozilla/5.0 (Android;Linux armv7l;rv:2.2a1pre)Gecko/20110330
Firefox/4.2a1pre Fennec /4.01a1pre
Device: Samsung Galaxy S Captivate
OS: Android 2.1 update 1

Steps to reproduce:
1. Go to AMO or www.bugzilla.mozilla.org
2. Tap the favicon 

Actual result:
- option "Add search enginer" is not present in the pop up menu

Expected result: 
- option "Add search enginer" is present in the pop up menu

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

This is likely a regression from http://hg.mozilla.org/mozilla-central/rev/c1f5c784a38b , i have a patch for that but I think we need to ensure the failure is expected first.

Comment 2

[Jan de Mooij [:jandem]]

Bug 582717 made regular expressions not callable, so this is expected.

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 522991 [details] [diff] [review]
Patch

(In reply to comment #2)
> Bug 582717 made regular expressions not callable, so this is expected.

Thanks for the info.

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

http://hg.mozilla.org/mobile-browser/rev/bba3e2c500df

Comment 5

[Andreea Pod]

Verified on build: Mozilla /5.0 (Android;Linux armv7l;rv:2.2a1pre) Gecko/20110331 Firefox/4.2a1pre Fennec /4.1a1pre 
Device: HTC Desire