646519 - DOM Inspector's window icon isn't shown in FF4

Status: RESOLVED FIXED

(Other Applications :: DOM Inspector, defect)

Description

[Glenn Maynard]

User-Agent:       Mozilla/5.0 (Windows NT 5.2; WOW64; rv:2.0) Gecko/20100101 Firefox/4.0
Build Identifier: 

DOM Inspector's window icon is no longer being used in FF4.

This looks like it's due to this change:

  https://developer.mozilla.org/en/Bundles#Platform-specific_files

I often have 2-3 Inspector windows open along with 3-4 Firefox windows, and they're much harder to distinguish now.  I've temporarily worked around this locally by moving the WINNT icon into the main component (chrome/icons/default/winInspectorMain.ico).


Reproducible: Always

Comment 1

[:aceman]

Can confirm on Linux too, FF5 and FF7. The DOM Inspector icon is the same as the main FF icon.

Comment 2

[Javi Rueda :javirid]

I have been able to fix it in both Windows and Linux (here I had to switch to Gnome to see the icon, as Unity doesn't likes to show it on a bar).

The problem is that the solution doesn't allow to use the icon file for OS/2, as it share name with Windows one.

I will try to fix it for OS/2 also. Anyone have an idea? There is a way to install files depending of the OS by using flags. But it is seems that this is useless for this directory. Will try, anyway.

My patch installs ico and xpm files to the directory chrome/icons/defaults instead of the now disallowed platform/ directory, as "recommended" by extensions documentation at MDN.

Comment 3

[Shawn Wilsher :sdwilsh]

I'm not sure we even build for OS/2 anymore, so I wouldn't spend too much time worrying about it.

Comment 4

[Javi Rueda :javirid]

Attachment: Applies to the no-platform-especific-dirs policy and removes OS/2 icon.

Changes location of the window icons for Linux and Windows, following the new policy of XUL that doesn't allow resources to have platform specific directories.

As icons are loaded by name and OS/2 uses exact match name as Windows, OS/2 icons are removed from the repository.

Comment 5

[Javi Rueda :javirid]

ping

Comment 6

[[e-mail]]

Comment on attachment 575682 [details] [diff] [review]
Applies to the no-platform-especific-dirs policy and removes OS/2 icon.

>+	$(NSINSTALL) -D $(FINAL_TARGET)/chrome/icons/default
>+	$(INSTALL) $(srcdir)/resources/content/res/Linux/winInspectorMain.xpm $(FINAL_TARGET)/chrome/icons/default
>+	$(INSTALL) $(srcdir)/resources/content/res/Linux/winInspectorMain16.xpm $(FINAL_TARGET)/chrome/icons/default
>+	$(NSINSTALL) -D $(FINAL_TARGET)/chrome/icons/default
Don't need to do this twice. r=me with the second one removed.

Comment 7

[Javi Rueda :javirid]

Attachment: patch

Patch with the additional useless NSINSTALL removed.

Asking for check-in if nor Neil neither Colby has anything to comment.

Thank you for the review, Neil.

Comment 8

[[e-mail]]

Comment on attachment 582609 [details] [diff] [review]
patch

(Marking r+ for completeness)

Comment 9

[[e-mail]]

Pushed changeset d4753a1a170f to dom-inspector.