646598 - adding too many message event listeners

Status: RESOLVED FIXED

(Cloud Services :: Share: Firefox Client, defect)

Description

[Shane Caraveo (:mixedpuppy)]

Instead of adding only one message event listener for the panel browser, we're adding one per tab opened plus one.  This is a leftover from when we switched to using the panel rather than a share browser embedded into each tab.  Further, these listeners are never removed, so the more browser tabs opened, the more message event handlers being called to do things like generate thumbnails.

This is likely the cause of bug 642629.

Comment 1

[Shane Caraveo (:mixedpuppy)]

Attachment: fix content-document-global-created listener

This patch enforces that we only add the message event listener when the browser in the share panel loads content.  We still do not remove the listener on unload, since that is handled for us when the content window in the browser dies.  We need to continue listening on content-document-global-created since there are situations where a different url is loaded into the share panel browser (e.g. server down)

Comment 2

[Shane Caraveo (:mixedpuppy)]

Attachment: use onload to attach message listener

using onload per discussion with philikon

Comment 3

[Philipp von Weitershausen [:philikon]]

Comment on attachment 523093 [details] [diff] [review]
use onload to attach message listener

Looks good, I'll land it in fx-share.

Comment 4

[Philipp von Weitershausen [:philikon]]

https://hg.mozilla.org/users/pweitershausen_mozilla.com/fx-share/rev/a3d4a0bea42e