646605 - sanitycheck.pl should be able to accept repair actions and pass them to sanitycheck.cgi

Status: NEW

(Bugzilla :: Administration, task, P3)

Description

[Kent Rogers [:mrbball]]

User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.15) Gecko/20110308 Fedora/3.6.15-1.fc14 Firefox/3.6.15
Build Identifier: 4.1.1+

It would be nice if sanitycheck.pl were enhanced with an option where
the user could specify repair actions (e.g. rescanallBugMail) to take in
sanitycheck.cgi.

For example, say we wanted to run a cron job regularly to make sure that
no unsent email lingered, it would be nice if sanitycheck.pl had a
--action option where the caller could specify 'rescanallBugMail' and
have that get passed to sanitycheck.cgi as an argument (e.g.
rescanallBugMail=1).

Also, a couple of other observations of sanitycheck.pl:

- If no login is specified, it may be more appropriate to throw a
  'login_required' error than an 'invalid_username' error.
- Although emailing the output of sanitycheck.cgi to the user is a nice
  option, it seems counterintuitive to have that be the default.  I'd
  rather see the output default to stdout, and at the very least, there
  should be an option to do that.

I can submit a patch with these enhancements, if acceptable.


Reproducible: Always