Always enable Close Tab in the tab context menu

RESOLVED FIXED in seamonkey2.1b3

Status

SeaMonkey
Tabbed Browser
--
minor
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: InvisibleSmiley, Assigned: InvisibleSmiley)

Tracking

Trunk
seamonkey2.1b3

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

7 years ago
Created attachment 523098 [details] [diff] [review]
patch

Bug 533125 added support for browser.tabs.closeWindowWithLastTab and took care about the menuitem under File (cf. navigator.js). What's missing is middle clicking and the tab context menu, which still disables Close Tab if the pref is set to false.
Attachment #523098 - Flags: review?(neil)

Comment 1

7 years ago
(In reply to comment #0)
> Bug 533125 added support for browser.tabs.closeWindowWithLastTab and took care
> about the menuitem under File (cf. navigator.js). What's missing is middle
> clicking and the tab context menu, which still disables Close Tab if the pref
> is set to false.
The tab close button always closes the tab, never the window, irrespective of the pref, and I think that middle-clicking should have the same behaviour. I agree that disabling close tab on the context menu is wrong, but as yet I'm not convinced that we actually need to disable it at all.
(Assignee)

Comment 2

7 years ago
(In reply to comment #1)
> The tab close button always closes the tab, never the window, irrespective of
> the pref, and I think that middle-clicking should have the same behaviour.

OK, valid point. Didn't think of the tab bar close button; it's just too far away to be useful to me so I tend to forget about its existence. ;-)

> I agree that disabling close tab on the context menu is wrong, but as yet I'm
> not convinced that we actually need to disable it at all.

I think we do because otherwise people may accidentally close the whole application (in case only a browser window is open) while expecting to close just the tab. Basically one of these cases that might become a trap for non-power users. [The alternative would be to rename the context menu item in that case but I don't like that idea.]
(Assignee)

Updated

7 years ago
Summary: Make tab middle click and Close Tab in context menu aware of browser.tabs.closeWindowWithLastTab → Make Close Tab in context menu aware of browser.tabs.closeWindowWithLastTab

Comment 3

7 years ago
(In reply to comment #2)
> (In reply to comment #1)
> > I agree that disabling close tab on the context menu is wrong, but as yet I'm
> > not convinced that we actually need to disable it at all.
> I think we do because otherwise people may accidentally close the whole
> application (in case only a browser window is open) while expecting to close
> just the tab.
The close tab context menuitem would never do that; like the close button it only knows how to close tabs.
(Assignee)

Comment 4

7 years ago
Created attachment 523426 [details] [diff] [review]
always enable Close Tab [Checkin: comment 6]

Well, then: one-liner.
Attachment #523098 - Attachment is obsolete: true
Attachment #523098 - Flags: review?(neil)
Attachment #523426 - Flags: review?(neil)

Comment 5

7 years ago
Comment on attachment 523426 [details] [diff] [review]
always enable Close Tab [Checkin: comment 6]

BTW Ctrl+F4 also always works if the tab bar is visible.
Attachment #523426 - Flags: review?(neil) → review+
(Assignee)

Updated

7 years ago
Summary: Make Close Tab in context menu aware of browser.tabs.closeWindowWithLastTab → Always enable Close Tab in the tab context menu
(Assignee)

Comment 6

7 years ago
Comment on attachment 523426 [details] [diff] [review]
always enable Close Tab [Checkin: comment 6]

http://hg.mozilla.org/comm-central/rev/e1f6155dfa8d
Attachment #523426 - Attachment description: always enable Close Tab → always enable Close Tab [Checkin: comment 6]
(Assignee)

Updated

7 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1b3
You need to log in before you can comment on or make changes to this bug.