Closed Bug 64665 Opened 25 years ago Closed 25 years ago

Text edit rules hardwire wrap width to 72

Categories

(Core :: DOM: Editor, defect)

x86
Linux
defect
Not set
normal

Tracking

()

VERIFIED FIXED
mozilla0.9

People

(Reporter: akkzilla, Assigned: akkzilla)

Details

Attachments

(2 files)

nsTextEditRules.cpp: if (!alreadyPlaintext && willBePlaintext) { // Call the editor's SetWrapWidth(), which will // set the styles appropriately for plaintext: mEditor->SetWrapWidth(72); } The editor has code to get the wrap width, but the rules are overriding this. Is there a reason for this? Can I remove that clause?
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9
Joe, any idea why they're hardwired? Assign back to me if you're overloaded.
Assignee: akkana → jfrancis
Status: ASSIGNED → NEW
i never had any clue what was going on with the wrapping. If you didn't put in the hardcode then I don't know who did. (cvsblame may show me, i haven't looked, but if it does it's just from me shuffling code around.)
Assignee: jfrancis → akkana
Okay, I propose to just remove that clause, then, since the editor should set the width appropriately in its output routines. Patch coming. Can I get an r from Joe and an sr from Kin?
Status: NEW → ASSIGNED
Would this change affect mail plain text editor? I assume this change is only for html editor.
This is only for plaintext: the html edit rules don't do this.
r=jfrancis
I noticed that files saved with "save as" still weren't being saved with the wrap column, because we weren't setting the OutputWrap flag. I just attached a patch to nsEditor which fixes this, and also fixes a slew of compiler warnings. Kin, can you review these patches?
Fixed.
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Akkana, will I be able to verify this one? If not, can you do so? thanks!
Try setting the wrap column (in mail/news prefs) to different values, and make sure that the output changes accordingly.
verified in 1/30 build.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: