Status

defect
RESOLVED FIXED
9 years ago
8 years ago

People

(Reporter: philikon, Assigned: philikon)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

It r b0rken rite nao. Also needs tests.
Assignee: nobody → philipp
Blocks: 651668
yeah, we obviously want a clear message to the user, as opposed to an oddly formatted network error page filling part of our UI.
Inlining the progress listener into the FFShare object. No need for a separate object or even a separate JSM.
Attachment #529907 - Flags: review?(mixedpuppy)
Posted patch v1Splinter Review
Implement (=bring back) the network down page, but without any sort of styling. Need UX input for that, will deal with it in a follow-up.
Attachment #529908 - Flags: review?(mixedpuppy)
Depends on: 654624
(In reply to comment #3)
> Implement (=bring back) the network down page, but without any sort of styling.
> Need UX input for that, will deal with it in a follow-up.

Filed bug 654624.
Whiteboard: [has patch][needs review mixedpuppy]
Attachment #529907 - Flags: review?(mixedpuppy) → review+
Comment on attachment 529908 [details] [diff] [review]
v1

in panel.js PANEL_NETWORK_DOWN_PAGE and PREFS_NETWORK_DOWN_PAGE have the same url, are two needed?

Otherwise, r+
Attachment #529908 - Flags: review?(mixedpuppy) → review+
(In reply to comment #5)
> in panel.js PANEL_NETWORK_DOWN_PAGE and PREFS_NETWORK_DOWN_PAGE have the same
> url, are two needed?

Well, I imagine we'll use differently styled pages for the preference pane and the panel network down pages in bug 654624 and I wanted to make that change as easy as possible.
Whiteboard: [has patch][needs review mixedpuppy] → [has patch]
You need to log in before you can comment on or make changes to this bug.