646658 - Fix network down page

Status: RESOLVED FIXED

(Cloud Services :: Share: Firefox Client, defect)

Description

[Philipp von Weitershausen [:philikon]]

It r b0rken rite nao. Also needs tests.

Comment 1

[Alex Faaborg [:faaborg] (Firefox UX)]

yeah, we obviously want a clear message to the user, as opposed to an oddly formatted network error page filling part of our UI.

Comment 2

[Philipp von Weitershausen [:philikon]]

Attachment: prereq (v1): simplify gBrowser progress listener

Inlining the progress listener into the FFShare object. No need for a separate object or even a separate JSM.

Comment 3

[Philipp von Weitershausen [:philikon]]

Attachment: v1

Implement (=bring back) the network down page, but without any sort of styling. Need UX input for that, will deal with it in a follow-up.

Comment 4

[Philipp von Weitershausen [:philikon]]

(In reply to comment #3)
> Implement (=bring back) the network down page, but without any sort of styling.
> Need UX input for that, will deal with it in a follow-up.

Filed bug 654624.

Comment 5

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 529908 [details] [diff] [review]
v1

in panel.js PANEL_NETWORK_DOWN_PAGE and PREFS_NETWORK_DOWN_PAGE have the same url, are two needed?

Otherwise, r+

Comment 6

[Philipp von Weitershausen [:philikon]]

(In reply to comment #5)
> in panel.js PANEL_NETWORK_DOWN_PAGE and PREFS_NETWORK_DOWN_PAGE have the same
> url, are two needed?

Well, I imagine we'll use differently styled pages for the preference pane and the panel network down pages in bug 654624 and I wanted to make that change as easy as possible.

Comment 7

[Philipp von Weitershausen [:philikon]]

https://hg.mozilla.org/users/pweitershausen_mozilla.com/fx-share/rev/eff8ad9ed574
https://hg.mozilla.org/users/pweitershausen_mozilla.com/fx-share/rev/14571150607c