646678 - Fennec freezes/hangs at startup splash screen with URL Fixer add-on installed

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Extension Compatibility, defect)

Description

[Matt Brubeck (:mbrubeck)]

Steps to reproduce:
1. Install the URL Fixer add-on: https://addons.mozilla.org/mobile/addon/url-fixer/
2. Restart the browser.

This causes Fennec to hang at the "loading" splash screen.  Reported by a user on an HTC Desire HD, and reproduced in Firefox 4.0 on my HTC T-Mobile G2.  I don't see anything unusual in the Android logs.

Comment 1

[Matt Brubeck (:mbrubeck)]

Attachment: add-on XPI file

Comment 2

[Matt Brubeck (:mbrubeck)]

Looks like this add-on was just updated this week.  Can we get it temporarily removed from the "featured" list until cfinke can update it with a fix or remove the affected version?

Comment 3

[Matt Brubeck (:mbrubeck)]

I can also reproduce this in a local debug trunk build (if I force add-on compatibility).  The browser hangs after this output:

JavaScript strict warning: chrome://url-fixer/content/smartlinks.xul, line 1282: reference to undefined property window.getsmartlinks

...and resumes over a minute later with this:

JavaScript error: chrome://url-fixer/content/smartlinks.xul, line 833: too much recursion

Comment 4

[Matt Brubeck (:mbrubeck)]

The problem is that getPref() calls error() on line 833, but error() calls getPref().

Fennec is hitting this error call because:

getPref("off"…) ReferenceError: Application is not defined

Comment 5

[Christopher Finke]

Sorry about this; I had intended to only include the smartlinks.xul overlay in desktop Firefox.  I've added he appropriate application flag in chrome.manifest and uploaded the change as version 2.0.3.

I've also forwarded this error to the SmartLinks guys so they can either fix or explicitly exclude Fennec as a supported browser.

Comment 6

[Matt Brubeck (:mbrubeck)]

Thanks!  We're making sure 2.0.3 gets reviewed and pushed to public right away.

Comment 7

[Matt Brubeck (:mbrubeck)]

URL Fixer 2.0.3 is approved.

Comment 8

[Johan Sundström]

Thanks! Fixed upstream too.

Comment 9

[Andreea Pod]

Verified on build: Mozilla /5.0 (Android;Linux armv7l;rv:5.0a2) Gecko/20110414 Firefox/5.0a2 Fennec/5.0a2 
Device: LG Optimus 2X (Android 2.2)