646685 - Fix watchPosition after isBetterPosition was removed and cleanup android implementation

Status: RESOLVED FIXED

(Core :: DOM: Geolocation, defect)

Description

[Doug Turner (:dougt)]

Fix watchPosition after isBetterPosition was removed and cleanup android implementation.

After isBetterPosition was removed, I left mIsFirstUpdate.  This causes watchPosition never to fire more than once.  This patch also adjusts the Android implementation slightly to allow Geocoding to happen sooner.

Comment 1

[Doug Turner (:dougt)]

Attachment: patch v.1

Comment 2

[Brad Lassey [:blassey] (use needinfo?)]

as discussed, please file a follow up bug to unify how we get a reference to a Context in GeckoAppShell

Comment 3

[Doug Turner (:dougt)]

http://hg.mozilla.org/projects/cedar/rev/c5bd92bec6d6

Comment 4

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/c5bd92bec6d6

Comment 5

[Daniel Veditz [:dveditz]]

Comment on attachment 523164 [details] [diff] [review]
patch v.1

Approved for the mozilla2.0 repository, a=dveditz for release-drivers

Comment 6

[Doug Turner (:dougt)]

thanks dan.  I may have *not* screwed up.  I don't think i broke this in 4.0.... as it turns out.

Comment 7

[(no longer active)]

FWIW, this patch doesn't apply on 2.0.