Closed Bug 646685 Opened 9 years ago Closed 9 years ago

Fix watchPosition after isBetterPosition was removed and cleanup android implementation

Categories

(Core :: DOM: Geolocation, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla5

People

(Reporter: dougt, Assigned: dougt)

Details

Attachments

(1 file)

Fix watchPosition after isBetterPosition was removed and cleanup android implementation.

After isBetterPosition was removed, I left mIsFirstUpdate.  This causes watchPosition never to fire more than once.  This patch also adjusts the Android implementation slightly to allow Geocoding to happen sooner.
Attached patch patch v.1Splinter Review
Attachment #523164 - Flags: review?(blassey.bugs)
Assignee: nobody → doug.turner
Attachment #523164 - Flags: review?(blassey.bugs) → review+
as discussed, please file a follow up bug to unify how we get a reference to a Context in GeckoAppShell
Attachment #523164 - Flags: approval2.0?
blocking2.0: --- → ?
http://hg.mozilla.org/projects/cedar/rev/c5bd92bec6d6
blocking2.0: ? → ---
status2.0: --- → ?
Whiteboard: fixed-in-cedar
status2.0: ? → ---
http://hg.mozilla.org/mozilla-central/rev/c5bd92bec6d6
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: fixed-in-cedar
Target Milestone: --- → mozilla2.2
Comment on attachment 523164 [details] [diff] [review]
patch v.1

Approved for the mozilla2.0 repository, a=dveditz for release-drivers
Attachment #523164 - Flags: approval2.0? → approval2.0+
blocking2.0: --- → Macaw
status2.0: --- → wanted
thanks dan.  I may have *not* screwed up.  I don't think i broke this in 4.0.... as it turns out.
blocking2.0: Macaw → ---
status2.0: wanted → ---
FWIW, this patch doesn't apply on 2.0.
You need to log in before you can comment on or make changes to this bug.