Closed
Bug 646731
Opened 14 years ago
Closed 14 years ago
Avoid promotion to double in IsPaddingZero and IsMarginZero
Categories
(Core :: Layout, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: jrmuizel, Assigned: jrmuizel)
Details
Attachments
(1 file)
|
1.04 KB,
patch
|
dbaron
:
review+
|
Details | Diff | Splinter Review |
Caught with -Wdouble-promotion. This may not impact codegen but it's more correct.
Attachment #523209 -
Flags: review?(dbaron)
|
||
Updated•14 years ago
|
Attachment #523209 -
Attachment is patch: true
Attachment #523209 -
Attachment mime type: application/octet-stream → text/plain
Comment on attachment 523209 [details] [diff] [review]
Using an integer literal will cause us to promote to the right type
Can you do 0.0f? I'd sort of prefer that. But r=dbaron either way, I guess.
Attachment #523209 -
Flags: review?(dbaron) → review+
|
Assignee | |
Comment 2•14 years ago
|
||
(In reply to comment #1)
> Comment on attachment 523209 [details] [diff] [review]
> Using an integer literal will cause us to promote to the right type
>
> Can you do 0.0f? I'd sort of prefer that. But r=dbaron either way, I guess.
Done.
http://hg.mozilla.org/mozilla-central/rev/8adbca2b3518
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
||
Updated•14 years ago
|
Assignee: nobody → jmuizelaar
You need to log in
before you can comment on or make changes to this bug.
Description
•