Created attachment 523321 [details] [diff] [review] add the encoding key to the desktop file used by specfile According to the most recent spec  the Encoding desktop file key is deprecated. Unfortunately, our build slaves are using an old version of desktop-file-utils. In the meanwhile, adding the encoding key to the desktop file will let us validate the desktop files on centos 5.0 while showing a warning on recent versions of fedora Error on Centos /builds/slave/cen-lnx64-rpm-ntly/build/obj-firefox/dist/rpmbuild/SOURCES/firefox.desktop: error: required key "Encoding" not found Warning on Fedora: mozilla.desktop: warning: key "Encoding" in group "Desktop Entry" is deprecated I have already filed bug 646764 to add a recent version of the desktop-file-validate program to fix the issue.  http://standards.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html#deprecated-items
Created attachment 523342 [details] [diff] [review] working patch The last patch was missing some lines because of a bad copy and paste
Assignee: nobody → jhford
Attachment #523321 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #523342 - Flags: review?(mh+mozilla)
Attachment #523342 - Flags: review?(mh+mozilla) → review+
Created attachment 523400 [details] [diff] [review] changeset for cjones to check in So that Chris can check in this patch. Thanks Chris!
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.