Closed
Bug 646851
Opened 14 years ago
Closed 14 years ago
build slaves not able to build rpms because of old version of desktop-file-utils
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jhford, Assigned: jhford)
References
()
Details
Attachments
(2 files, 1 obsolete file)
379 bytes,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
670 bytes,
patch
|
Details | Diff | Splinter Review |
According to the most recent spec [1] the Encoding desktop file key is deprecated. Unfortunately, our build slaves are using an old version of desktop-file-utils. In the meanwhile, adding the encoding key to the desktop file will let us validate the desktop files on centos 5.0 while showing a warning on recent versions of fedora
Error on Centos
/builds/slave/cen-lnx64-rpm-ntly/build/obj-firefox/dist/rpmbuild/SOURCES/firefox.desktop: error: required key "Encoding" not found
Warning on Fedora:
mozilla.desktop: warning: key "Encoding" in group "Desktop Entry" is deprecated
I have already filed bug 646764 to add a recent version of the desktop-file-validate program to fix the issue.
[1] http://standards.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html#deprecated-items
Assignee | ||
Comment 1•14 years ago
|
||
The last patch was missing some lines because of a bad copy and paste
Assignee | ||
Updated•14 years ago
|
Attachment #523342 -
Flags: review?(mh+mozilla)
Updated•14 years ago
|
Attachment #523342 -
Flags: review?(mh+mozilla) → review+
Assignee | ||
Comment 2•14 years ago
|
||
So that Chris can check in this patch. Thanks Chris!
Assignee | ||
Updated•14 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•