build slaves not able to build rpms because of old version of desktop-file-utils

RESOLVED FIXED

Status

Firefox Build System
General
RESOLVED FIXED
7 years ago
2 months ago

People

(Reporter: jhford, Assigned: jhford)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(2 attachments, 1 obsolete attachment)

Created attachment 523321 [details] [diff] [review]
add the encoding key to the desktop file used by specfile

According to the most recent spec [1] the Encoding desktop file key is deprecated.  Unfortunately, our build slaves are using an old version of desktop-file-utils.  In the meanwhile, adding the encoding key to the desktop file will let us validate the desktop files on centos 5.0 while showing a warning on recent versions of fedora

Error on Centos
/builds/slave/cen-lnx64-rpm-ntly/build/obj-firefox/dist/rpmbuild/SOURCES/firefox.desktop: error: required key "Encoding" not found

Warning on Fedora:
mozilla.desktop: warning: key "Encoding" in group "Desktop Entry" is deprecated


I have already filed bug 646764 to add a recent version of the desktop-file-validate program to fix the issue.



[1] http://standards.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html#deprecated-items
Blocks: 600317
Created attachment 523342 [details] [diff] [review]
working patch

The last patch was missing some lines because of a bad copy and paste
Assignee: nobody → jhford
Attachment #523321 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #523342 - Flags: review?(mh+mozilla)
Attachment #523342 - Flags: review?(mh+mozilla) → review+
Created attachment 523400 [details] [diff] [review]
changeset for cjones to check in

So that Chris can check in this patch.  Thanks Chris!
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED

Updated

2 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.