test_initial_computation and test_value_computation fail in Japanese and other locales

NEW
Unassigned

Status

()

Core
CSS Parsing and Computation
7 years ago
7 years ago

People

(Reporter: dbaron, Unassigned)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

layout/style/test/test_initial_computation.html
layout/style/test/test_value_computation.html
fail in Japanese locale, and I suspect in any other locales where the default serif/sans-serif preference differs from Western locales.

I thought maybe the underlying problem is that nsPresContext::UpdateCharSet needs to call RebuildAllStyleData() after calling GetFontPreferences, but that doesn't seem to be it.  (Though it's possible that it does -- if we ever have any style data to rebuild when UpdateCharSet is called.)

Steps to reproduce:
LANG=ja_JP.UTF-8 LC_ALL=ja_JP.UTF-8 TEST_PATH=layout/style make mochitest-plain
Could also be another instance of bug 416581.
Depends on: 416581
This seems to be fixed by the patch is bug 416581.
Wait. I ran the command from comment 0 in the wrong tree (one without the patch from bug 416581). Did something else fix this bug?
On what platform?  The locale codes for Japanese might be different.  Does:
LANG=ja_JP.UTF-8 LC_ALL=ja_JP.UTF-8 date
produce output like:
2012年  1月 31日 火曜日 15:16:39 CET
?
(And that particular command works on one of my two Ubuntu 11.10 machines and not the other -- and I don't know what the difference is other than guessing it's related to a package that's installed on one and not the other.)
(To be clear, I wasn't able to try the mochitest command, since the one with the development environment is the one where that command doesn't work.)
jwatt$ LANG=ja_JP.UTF-8 LC_ALL=ja_JP.UTF-8 date
2012年 1月31日 火曜日 14時35分16秒 GMT

So it seems to work for me. This is on OS X 10.7, recent m-c, debug build created using Xcode 4.2.
Though it's possible that locale stuff on Mac OS X is controlled by something less Unixish than environment variables...
You need to log in before you can comment on or make changes to this bug.