Closed
Bug 646970
Opened 14 years ago
Closed 14 years ago
Remove controller argument from _buildMenu call in Menu::open() in controller.js
Categories
(Testing Graveyard :: Mozmill, defect)
Testing Graveyard
Mozmill
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: aaronmt, Assigned: aaronmt)
References
Details
(Keywords: regression, Whiteboard: [mozmill-1.5.3+])
Attachments
(1 file)
|
849 bytes,
patch
|
whimboo
:
review+
|
Details | Diff | Splinter Review |
Discovered this while using Menu::open, wasn't sure why I was getting a "Can't convert undefined to object" exception on my XUL element, turns out it was acting on the controller.
https://github.com/mozautomation/mozmill/blob/master/mozmill/mozmill/extension/resource/modules/controller.js#L148
|
||
Updated•14 years ago
|
Component: Mozmill Automation → Mozmill
Product: Mozilla QA → Testing
QA Contact: mozmill-automation → mozmill
|
Assignee | |
Updated•14 years ago
|
Summary: Remove controller argument from _buildMenu call Menu::open() in controller.js → Remove controller argument from _buildMenu call in Menu::open() in controller.js
|
|
||
Comment 1•14 years ago
|
||
Clint, this is a nasty regression from bug 597330 and needs to be fixed so we can really use the menu API. It's a trivial fix.
Blocks: 597330
Keywords: regression
|
|
Assignee | |
Comment 2•14 years ago
|
||
Here's the simple fix, requesting Henrik for review.
|
|
||
Comment 3•14 years ago
|
||
Comment on attachment 523448 [details] [diff] [review]
Patch v1 - (master)
I still can't believe that the controller went in as parameter. I wonder how the handling of the main menu was working since this check-in.
Attachment #523448 -
Flags: review?(hskupin) → review+
|
|
Assignee | |
Comment 5•14 years ago
|
||
I don't have write access to mozautomation/mozmill. Feel free to push.
|
|
||
Comment 6•14 years ago
|
||
With this patch the test 'mozmill/test/test_menu.js' will also pass now.
Landed as:
https://github.com/mozautomation/mozmill/commit/385b6dd36d6d73a276c52aef516bed77f1b06db7 (hotfix-1.5)
https://github.com/mozautomation/mozmill/commit/702dcadce3cfbd878910e6b9b06e98595fb06580 (master)
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
|
||
Updated•9 years ago
|
Product: Testing → Testing Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•