647072 - On roll over, Super-User quote should be static

Status: VERIFIED FIXED

Description

[Laura Mesa [:lmesa] [:lvmesa]]

Created attachment 523476 [details]
static box

The quote box for each super user should be static while the user remains highlighted. Upon navigation away from the mark, the box should go away. 

See image attached.

Comment 1

[Adam Miller]

Fixed here: https://github.com/mozilla/markup/commit/91921f4bd0f528029c4ca12c923a498035bb4f9d#diff-32

Comment 2

[Laura Mesa [:lmesa] [:lvmesa]]

This is not working on our stage server. 

Test for yourself here: https://markup.allizom.org/accounts/login/ u: admin p: cH568Efruxas

Comment 3

[Fred Wenzel [:wenzel]]

(In reply to comment #2)
> This is not working on our stage server. 
> 
> Test for yourself here: https://markup.allizom.org/accounts/login/ u: admin p:
> cH568Efruxas

:-/ this is a public bug. I changed the admin password and updated it in the internal markup docs. Please share the credentials by email instead if needed.

Comment 4

[Laura Mesa [:lmesa] [:lvmesa]]

(In reply to comment #3)
> (In reply to comment #2)
> > This is not working on our stage server. 
> > 
> > Test for yourself here: https://markup.allizom.org/accounts/login/ u: admin p:
> > cH568Efruxas
> 
> :-/ this is a public bug. I changed the admin password and updated it in the
> internal markup docs. Please share the credentials by email instead if needed.

I'm a knuckle head! Sorry about that. Adam--sending you new credentials by email now.

Comment 5

[Adam Miller]

Laura, what's the bug here? 

Why are you directing me to the admin login? The contributor, or superuser, marks shouldn't ever show up in the admin tool. I can view this one:

https://markup.allizom.org/en/#/linear/dKax

And the quote from Matt behaves as I expected.

Comment 6

[Laura Mesa [:lmesa] [:lvmesa]]

The bug here is that the quote should be present at all times when its in the center of the viewing pane. Right now, its only present on rollover, so the discover-ability is low. We want to make it obvious that these marks are different, so highlighting is one way, but the quote is also key.

Comment 7

[Adam Miller]

Sorry, I misunderstood this bug initially. I need to talk to Henry about this change before I finish my fix, but it's underway.

Comment 8

[Adam Miller]

Fixed here: 

https://github.com/mozilla/markup/commit/33ce29207e830bdbc094f42d7f0ee178e3408bc1

Comment 9

[Matt Brandt [:mbrandt]]

:lmesa, if you've got a moment can you verify the fix?

Comment 10

[Laura Mesa [:lmesa] [:lvmesa]]

Works for me!